Light refactoring.

Author: jeffposnick

src/index.js

@@ -78,7 +78,10 @@ class PreloadPlugin {
       // If we're preloading this resource (as opposed to prefetching),
       // then we need to set the 'as' attribute correctly.
       if (options.rel === 'preload') {
-        attributes.as = determineAsValue(options.as, href);
+        attributes.as = determineAsValue({
+          href,
+          optionsAs: options.as,
+        });
 
         // On the off chance that we have a cross-origin 'href' attribute,
         // set crossOrigin on the <link> to trigger CORS mode. Non-CORS
@@ -88,11 +91,17 @@ class PreloadPlugin {
         }
       }
 
-      const linkElementString = createHTMLElementString('link', attributes);
+      const linkElementString = createHTMLElementString({
+        attributes,
+        elementName: 'link',
+      });
       links.push(linkElementString);
     }
 
-    htmlPluginData.html = insertLinksIntoHead(htmlPluginData.html, links);
+    htmlPluginData.html = insertLinksIntoHead({
+      links,
+      html: htmlPluginData.html,
+    });
 
     return htmlPluginData;
   }

src/lib/create-html-element-string.js

@@ -17,7 +17,7 @@
 
 const assert = require('assert');
 
-function createHTMLElementString(elementName, attributes={}, closingTagRequired=false) {
+function createHTMLElementString({elementName, attributes={}, closingTagRequired=false}) {
   assert(elementName, 'Please provide an element name.');
   assert(!(/\W/.test(elementName)), 'The element name contains invalid characters.');
 

src/lib/determine-as-value.js

@@ -19,7 +19,7 @@ const assert = require('assert');
 const path = require('path');
 const {URL} = require('url');
 
-function determineAsAttribute(optionsAs, href) {
+function determineAsValue({optionsAs, href}) {
   assert(href, `The 'href' parameter was not provided.`);
 
   switch (typeof optionsAs) {
@@ -55,4 +55,4 @@ function determineAsAttribute(optionsAs, href) {
   }
 }
 
-module.exports = determineAsAttribute;
+module.exports = determineAsValue;

src/lib/does-chunk-belong-to-html.js

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-function v3({chunk, htmlAssetsChunks, visitedChunks = {}}) {
+function v3({chunk, htmlAssetsChunks, visitedChunks={}}) {
   // Prevent circular recursion.
   // See https://github.com/GoogleChromeLabs/preload-webpack-plugin/issues/49
   if (visitedChunks[chunk.renderedHash]) {

src/lib/insert-links-into-head.js

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-function insertLinksIntoHead(html, links) {
+function insertLinksIntoHead({html, links=[]}) {
   if (links.length === 0) {
     return html;
   }