Skip to content

Commit fdaf52c

Browse files
committed
Fix tests
1 parent b57e6b3 commit fdaf52c

File tree

1 file changed

+5
-29
lines changed

1 file changed

+5
-29
lines changed

tests/unit/test_session.py

Lines changed: 5 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,7 +1011,7 @@ def test_create_session_with_default_datasource_env_var(
10111011
0
10121012
]
10131013
self.assertNotIn(
1014-
"spark.datasource.bigquery.writeMethod",
1014+
"spark.sql.sources.default",
10151015
create_session_request.session.runtime_config.properties,
10161016
)
10171017
mock_logger.warning.assert_not_called()
@@ -1034,18 +1034,6 @@ def test_create_session_with_default_datasource_env_var(
10341034
0
10351035
]
10361036
# BigQuery properties should be set
1037-
self.assertEqual(
1038-
create_session_request.session.runtime_config.properties.get(
1039-
"spark.datasource.bigquery.writeMethod"
1040-
),
1041-
"direct",
1042-
)
1043-
self.assertEqual(
1044-
create_session_request.session.runtime_config.properties.get(
1045-
"spark.datasource.bigquery.viewsEnabled"
1046-
),
1047-
"true",
1048-
)
10491037
self.assertEqual(
10501038
create_session_request.session.runtime_config.properties.get(
10511039
"spark.sql.sources.default"
@@ -1078,7 +1066,7 @@ def test_create_session_with_default_datasource_env_var(
10781066
0
10791067
]
10801068
self.assertNotIn(
1081-
"spark.datasource.bigquery.writeMethod",
1069+
"spark.sql.sources.default",
10821070
create_session_request.session.runtime_config.properties,
10831071
)
10841072
mock_logger.warning.assert_called_once_with(
@@ -1099,7 +1087,7 @@ def test_create_session_with_default_datasource_env_var(
10991087
dataproc_config = Session()
11001088
dataproc_config.runtime_config.version = "3.0"
11011089
dataproc_config.runtime_config.properties = {
1102-
"spark.datasource.bigquery.writeMethod": "override_method",
1090+
"spark.sql.sources.default": "override_source",
11031091
"spark.some.other.property": "some_value",
11041092
}
11051093
session = DataprocSparkSession.builder.dataprocSessionConfig(
@@ -1112,24 +1100,12 @@ def test_create_session_with_default_datasource_env_var(
11121100
]
11131101
# The BigQuery default properties should be set,
11141102
# but pre-existing properties should override defaults.
1115-
self.assertEqual(
1116-
create_session_request.session.runtime_config.properties.get(
1117-
"spark.datasource.bigquery.writeMethod"
1118-
),
1119-
"override_method",
1120-
) # Pre-existing property remains
1121-
self.assertEqual(
1122-
create_session_request.session.runtime_config.properties.get(
1123-
"spark.datasource.bigquery.viewsEnabled"
1124-
),
1125-
"true",
1126-
) # Default should still be set
11271103
self.assertEqual(
11281104
create_session_request.session.runtime_config.properties.get(
11291105
"spark.sql.sources.default"
11301106
),
1131-
"bigquery",
1132-
) # Default should still be set
1107+
"override_source",
1108+
) # Pre-existing property remains
11331109
self.assertEqual(
11341110
create_session_request.session.runtime_config.properties.get(
11351111
"spark.sql.catalog.spark_catalog"

0 commit comments

Comments
 (0)