Skip to content

Commit 9a0bbda

Browse files
authored
add addition label to release label workflow (#3263)
* add addition label to release label workflow * address review comments
1 parent cb18ecc commit 9a0bbda

File tree

3 files changed

+21
-9
lines changed

3 files changed

+21
-9
lines changed

.github/release.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,23 @@
1+
# Note: If updating these categories, also update
2+
# .github/workflows/release-notes-labels.yml and
3+
# contributor-docs/code-contributions.md.
14
changelog:
25
exclude:
36
labels:
47
- ignore-for-release
58
categories:
6-
- title: New Templates
9+
- title: Additional New Features
710
labels:
8-
- new-template
11+
- addition
12+
- title: Bug fixes
13+
labels:
14+
- bug-fix
915
- title: Improvements
1016
labels:
1117
- improvement
12-
- title: Bug fixes
18+
- title: New Templates
1319
labels:
14-
- bug-fix
20+
- new-template
1521
- title: Package Upgrades
1622
labels:
1723
- package-upgrade

.github/workflows/release-notes-labels.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,13 @@ jobs:
1313
with:
1414
mode: minimum
1515
count: 1
16+
# Note: If updating these labels, also update .github/release.yml
17+
# and contributor-docs/code-contributions.md.
1618
labels: |
19+
addition
20+
bug-fix
1721
ignore-for-release
18-
new-template
1922
improvement
20-
bug-fix
23+
new-template
2124
package-upgrade
22-
message: "This PR is being prevented from merging because you have not added any of the following labels: [ignore-for-release, new-template, improvement, bug-fix, package-upgrade]. You'll need to add one before this PR can be merged so that these can be used for release notes. For more information, see https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/contributor-docs/code-contributions.md#release-notes"
25+
message: "This PR is being prevented from merging because you have not added any of the following labels: [addition, bug-fix, ignore-for-release, improvement, new-template, package-upgrade]. You'll need to add one before this PR can be merged so that these can be used for release notes. For more information, see https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/contributor-docs/code-contributions.md#release-notes"

contributor-docs/code-contributions.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,8 +488,11 @@ Release notes are [automatically generated](https://docs.github.com/en/repositor
488488
based on the PR labels defined in [release.yml](https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/.github/release.yml).
489489
Before submitting your PR, a repo maintainer must add one of the following labels in order for all checks to pass:
490490

491+
- `addition`: Addition of new functionality
492+
- `bug-fix`: Fixes for bugs or issues in existing code
491493
- `ignore-for-release`: Changes that should not appear in release notes (e.g., documentation updates, internal refactoring)
492-
- `new-template`: Addition of new Dataflow templates
493494
- `improvement`: Enhancements to existing functionality or performance improvements
494-
- `bug-fix`: Fixes for bugs or issues in existing code
495+
- `new-template`: Addition of new Dataflow templates
495496
- `package-upgrade`: Updates to dependencies, libraries, or package versions
497+
498+
Note: If updating these labels, also update .github/release.yml and .github/workflows/release-notes-labels.yml.

0 commit comments

Comments
 (0)