Skip to content

Commit 26a73cf

Browse files
p3rf Teamcopybara-github
authored andcommitted
Refactor BUILD file to create container_service library
Also fix resulting pytype errors that this exposed. PiperOrigin-RevId: 846252648
1 parent 65f9e5e commit 26a73cf

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

perfkitbenchmarker/container_service/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import itertools
1818
import os
1919
import time
20-
from typing import Any, Iterable
20+
from typing import Any, Callable, Iterable
2121

2222
from absl import flags
2323
from perfkitbenchmarker import context
@@ -583,7 +583,7 @@ def GetNodePoolNames(self) -> list[str]:
583583

584584
def GetContainerClusterClass(
585585
cloud: str, cluster_type: str
586-
) -> type[BaseContainerCluster]:
586+
) -> Callable[[container_spec_lib.ContainerClusterSpec], BaseContainerCluster]:
587587
return resource.GetResourceClass(
588588
BaseContainerCluster, CLOUD=cloud, CLUSTER_TYPE=cluster_type
589589
)

perfkitbenchmarker/linux_benchmarks/kubernetes_ai_inference_benchmark.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,9 @@ def Run(
118118
cluster: container_service.KubernetesCluster = (
119119
benchmark_spec.container_cluster
120120
)
121-
server: k8s_server.WGServingInferenceServer = cluster.inference_server
121+
server: kubernetes_inference_server.BaseKubernetesInferenceServer | None = (
122+
cluster.inference_server
123+
)
122124
if not server or not isinstance(server, k8s_server.WGServingInferenceServer):
123125
raise ValueError('Inference server is not initialized in the cluster.')
124126

0 commit comments

Comments
 (0)