"Fix" Sample.__eq__()

The previous implementation had 3 bugs:
* it didn't compare units
* it only compared metadata in one direction (which violates symmetry, i.e.
  x == y did not imply that y == x)
* as a consequency of lack of symmetry, there existed values x,y such that
  x == y was true AND x != y was true.

The "fix" is to just delete the method. This causes python to use the standard
tuple equality method instead (which does the right thing).

PiperOrigin-RevId: 716368687

Author: p3rf Team

perfkitbenchmarker/sample.py

@@ -145,21 +145,6 @@ def __new__(
         **kwargs,
     )
 
-  def __eq__(self, other) -> bool:
-    if not isinstance(other, Sample):
-      # don't attempt to compare against unrelated types
-      return NotImplemented
-    if self.value != other.value:
-      return False
-    if self.metric != other.metric:
-      return False
-    if self.timestamp != other.timestamp:
-      return False
-    for key, value in other.metadata.items():
-      if key not in self.metadata or self.metadata[key] != value:
-        return False
-    return True
-
   def asdict(self) -> Dict[str, Any]:  # pylint:disable=invalid-name
     """Converts the Sample to a dictionary."""
     return self._asdict()

tests/linux_packages/aerospike_client_test.py

@@ -250,6 +250,11 @@ def testAggregateAsbenchSamples(self):
                     'window': 1,
                     'read_min': 61.0,
                     'read_max': 68863.0,
+                    'read_p50': 685.0,
+                    'read_p90': 1201.0,
+                    'read_p99': 2008.0,
+                    'read_p99.9': 3315.0,
+                    'read_p99.99': 45471.0,
                 },
                 timestamp=0,
             ),
@@ -265,6 +270,11 @@ def testAggregateAsbenchSamples(self):
                     'window': 1,
                     'write_min': 70.0,
                     'write_max': 16735.0,
+                    'write_p50': 726.0,
+                    'write_p90': 1248.0,
+                    'write_p99': 2008.0,
+                    'write_p99.9': 3577.0,
+                    'write_p99.99': 13183.0,
                 },
                 timestamp=0,
             ),
@@ -280,6 +290,11 @@ def testAggregateAsbenchSamples(self):
                     'window': 1,
                     'read_min': 61.0,
                     'read_max': 68863.0,
+                    'read_p50': 712.0,
+                    'read_p90': 1230.0,
+                    'read_p99': 2026.0,
+                    'read_p99.9': 3095.0,
+                    'read_p99.99': 18607.0,
                 },
                 timestamp=0,
             ),
@@ -295,6 +310,11 @@ def testAggregateAsbenchSamples(self):
                     'window': 1,
                     'write_min': 70.0,
                     'write_max': 16735.0,
+                    'write_p50': 750.0,
+                    'write_p90': 1278.0,
+                    'write_p99': 2071.0,
+                    'write_p99.9': 3137.0,
+                    'write_p99.99': 8575.0,
                 },
                 timestamp=0,
             ),
@@ -310,6 +330,11 @@ def testAggregateAsbenchSamples(self):
                     'window': 1,
                     'read_min': 61.0,
                     'read_max': 68863.0,
+                    'read_p50': 718.0,
+                    'read_p90': 1236.0,
+                    'read_p99': 2031.0,
+                    'read_p99.9': 2981.0,
+                    'read_p99.99': 10303.0,
                 },
                 timestamp=0,
             ),
@@ -325,6 +350,11 @@ def testAggregateAsbenchSamples(self):
                     'window': 1,
                     'write_min': 70.0,
                     'write_max': 16735.0,
+                    'write_p50': 755.0,
+                    'write_p90': 1280.0,
+                    'write_p99': 2063.0,
+                    'write_p99.9': 3013.0,
+                    'write_p99.99': 8511.0,
                 },
                 timestamp=0,
             ),