Skip to content

Commit bc3dda5

Browse files
jnguertincopybara-github
authored andcommitted
Improve logging for template rendering on SF.
PiperOrigin-RevId: 823709689
1 parent 6b3d0f2 commit bc3dda5

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

perfkitbenchmarker/providers/snowflake/snowflake.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -560,8 +560,8 @@ def CreateSearchIndex(
560560
data.ResourcePath(self.CREATE_INDEX_QUERY_TEMPLATE),
561561
query_name,
562562
context,
563+
should_log_file=True,
563564
)
564-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
565565
return self.client_interface.ExecuteQuery(query_name, print_results=True)
566566

567567
def DropSearchIndex(
@@ -576,8 +576,8 @@ def DropSearchIndex(
576576
data.ResourcePath(self.DELETE_INDEX_QUERY_TEMPLATE),
577577
query_name,
578578
context,
579+
should_log_file=True,
579580
)
580-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
581581
return self.client_interface.ExecuteQuery(query_name, print_results=True)
582582

583583
def GetSearchIndexCompletionPercentage(
@@ -592,8 +592,8 @@ def GetSearchIndexCompletionPercentage(
592592
data.ResourcePath(self.GET_INDEX_STATUS_QUERY_TEMPLATE),
593593
query_name,
594594
context,
595+
should_log_file=True,
595596
)
596-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
597597
_, meta = self.client_interface.ExecuteQuery(query_name, print_results=True)
598598
qres = int(meta['query_results']['COVERAGE_PERCENTAGE'][0])
599599
return qres, meta
@@ -609,8 +609,8 @@ def InitializeSearchStarterTable(
609609
data.ResourcePath(self.INITIALIZE_SEARCH_TABLE_QUERY_TEMPLATE),
610610
query_name,
611611
context,
612+
should_log_file=True,
612613
)
613-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
614614
return self.client_interface.ExecuteQuery(query_name, print_results=True)
615615

616616
def InsertSearchData(
@@ -625,8 +625,8 @@ def InsertSearchData(
625625
data.ResourcePath(self.LOAD_SEARCH_DATA_QUERY_TEMPLATE),
626626
query_name,
627627
context,
628+
should_log_file=True,
628629
)
629-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
630630
# Snowflake returns info for each csv file processed, which pollutes logs
631631
# and datapoints needlessly. So print_results=False.
632632
return self.client_interface.ExecuteQuery(query_name, print_results=False)
@@ -640,8 +640,8 @@ def GetTableRowCount(self, table_path: str) -> tuple[int, dict[str, Any]]:
640640
data.ResourcePath(self.GET_ROW_COUNT_QUERY_TEMPLATE),
641641
query_name,
642642
context,
643+
should_log_file=True,
643644
)
644-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
645645
_, meta = self.client_interface.ExecuteQuery(query_name, print_results=True)
646646
qres = int(meta['query_results']['TOTAL_ROW_COUNT'][0])
647647
return qres, meta
@@ -659,8 +659,8 @@ def TextSearchQuery(
659659
data.ResourcePath(self.INDEX_SEARCH_QUERY_TEMPLATE),
660660
query_name,
661661
context,
662+
should_log_file=True,
662663
)
663-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
664664
res, meta = self.client_interface.ExecuteQuery(
665665
query_name, print_results=True
666666
)
@@ -684,9 +684,8 @@ def _RunMetadataQuery(
684684
data.ResourcePath(query_template),
685685
query_name,
686686
context,
687+
should_log_file=True,
687688
)
688-
# log the query text
689-
self.client_interface.client_vm.RemoteCommand(f'cat {query_name}')
690689
_, output = self.client_interface.ExecuteQuery(
691690
query_name, print_results=True
692691
)

0 commit comments

Comments
 (0)