Skip to content

Commit da1e9dc

Browse files
Arushi-07copybara-github
authored andcommitted
Update fio latency sla benchmark code comments
PiperOrigin-RevId: 864524641
1 parent c38854c commit da1e9dc

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

perfkitbenchmarker/linux_benchmarks/fio/fio_latency_sla_benchmark.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,6 @@ def Run(spec: benchmark_spec.BenchmarkSpec) -> list[sample.Sample]:
138138
# any iodepth and numjobs combination.
139139
BaseCheck(vm, benchmark_params)
140140

141-
# We have seen that numjobs = vm's cpus/2 and iodepth = 1 might not meet the
142-
# latency target. In that case, we will reduce the numjobs by half and do
143-
# binary search over iodepth to find a configuration that meets the target.
144141
while numjobs > 0:
145142
left_iodepth = 1
146143
right_iodepth = max_iodepth
@@ -212,9 +209,12 @@ def Run(spec: benchmark_spec.BenchmarkSpec) -> list[sample.Sample]:
212209
if numjobs == 1:
213210
break
214211
if not latency_under_sla_samples:
215-
# latency target was never met for these numjobs
216212
numjobs_reduced = math.ceil(numjobs / 2)
217-
logging.error(
213+
# Initial Numjobs = vm's cpus/2 and iodepth = 1 might not meet the latency
214+
# target. Reducing the numjobs by half and performing binary search over
215+
# iodepth again to find a numjobs and iodepth configuration that meets the
216+
# target.
217+
logging.info(
218218
'We never reached latency target for %s, reducing numjobs to %s',
219219
numjobs,
220220
numjobs_reduced,

0 commit comments

Comments
 (0)