Add host maintenance start time to disruption trigger metadata.

PiperOrigin-RevId: 839934809

Author: raymond13513

perfkitbenchmarker/time_triggers/base_disruption_trigger.py

@@ -82,6 +82,7 @@ def GetMetadataForTrigger(self, event: DisruptionEvent) -> Dict[str, Any]:
     """Get the metadata for the trigger and append it to the samples."""
     return self.metadata | {
         'LM_total_time': event.total_time,
+        'Host_maintenance_start': event.start_time,
         'Host_maintenance_end': event.end_time,
     }
 

tests/time_triggers/base_disruption_trigger_test.py

@@ -56,11 +56,17 @@ def setUp(self):
 
   @mock.patch.object(time, 'time', mock.MagicMock(return_value=0))
   def testAppendSamples(self):
-    time_dic = {'LM_total_time': 10, 'Host_maintenance_end': 0}
+    time_dic = {
+        'LM_total_time': 10,
+        'Host_maintenance_end': 10,
+        'Host_maintenance_start': 4,
+    }
     s = []
     vm_spec = mock.MagicMock(spec=benchmark_spec.BenchmarkSpec)
     self.trigger.WaitForDisruption.return_value = [
-        base_disruption_trigger.DisruptionEvent(total_time=10, end_time=0)
+        base_disruption_trigger.DisruptionEvent(
+            total_time=10, end_time=10, start_time=4
+        )
     ]
     self.trigger.AppendSamples(None, vm_spec, s)
     self.assertEqual(
@@ -606,7 +612,9 @@ def testAppendLossFunctionSamplesWithDisruptionEnds(self):
     samples = [s]
     self.trigger.trigger_time = datetime.datetime.fromtimestamp(4)
     self.trigger.WaitForDisruption.return_value = [
-        base_disruption_trigger.DisruptionEvent(total_time=100, end_time=8)
+        base_disruption_trigger.DisruptionEvent(
+            total_time=100, end_time=8, start_time=4
+        )
     ]
     self.trigger.AppendSamples(None, vm_spec, samples)
     self.assertEqual(
@@ -685,6 +693,7 @@ def testAppendLossFunctionSamplesWithDisruptionEnds(self):
                     'interval': 1,
                     'LM_total_time': 100,
                     'Host_maintenance_end': 8,
+                    'Host_maintenance_start': 4,
                 },
                 timestamp=0,
             ),
@@ -803,7 +812,9 @@ def testAppendLossFunctionSamplesContainsMetadata(self):
     samples = [s]
     self.trigger.trigger_time = datetime.datetime.fromtimestamp(4)
     self.trigger.WaitForDisruption.return_value = [
-        base_disruption_trigger.DisruptionEvent(total_time=100, end_time=8)
+        base_disruption_trigger.DisruptionEvent(
+            total_time=100, end_time=8, start_time=4
+        )
     ]
     self.trigger.AppendSamples(None, vm_spec, samples)
     self.assertEqual(
@@ -884,6 +895,7 @@ def testAppendLossFunctionSamplesContainsMetadata(self):
                     'random': 'random',
                     'LM_total_time': 100,
                     'Host_maintenance_end': 8,
+                    'Host_maintenance_start': 4,
                 },
                 timestamp=0,
             ),
@@ -1005,7 +1017,9 @@ def testAppendLossFunctionSamplesHandleTimeDrift(self):
     samples = [s]
     self.trigger.trigger_time = datetime.datetime.fromtimestamp(4)
     self.trigger.WaitForDisruption.return_value = [
-        base_disruption_trigger.DisruptionEvent(total_time=100, end_time=11)
+        base_disruption_trigger.DisruptionEvent(
+            total_time=100, end_time=11, start_time=4
+        )
     ]
     self.trigger.AppendSamples(None, vm_spec, samples)
 
@@ -1035,6 +1049,7 @@ def testAppendLossFunctionSamplesHandleTimeDrift(self):
                     'random': 'random',
                     'LM_total_time': 100,
                     'Host_maintenance_end': 11,
+                    'Host_maintenance_start': 4,
                 },
                 timestamp=0,
             ),
@@ -1161,7 +1176,9 @@ def testMaintenanceEventTriggerAppendSamplesWithMaintenanceDegradationWindow(
     samples = [s]
     self.trigger.trigger_time = datetime.datetime.fromtimestamp(4)
     self.trigger.WaitForDisruption.return_value = [
-        base_disruption_trigger.DisruptionEvent(total_time=100, end_time=11)
+        base_disruption_trigger.DisruptionEvent(
+            total_time=100, end_time=11, start_time=4
+        )
     ]
     self.trigger.AppendSamples(None, vm_spec, samples)
     # Assertions
@@ -1191,6 +1208,7 @@ def testMaintenanceEventTriggerAppendSamplesWithMaintenanceDegradationWindow(
                     'random': 'random',
                     'LM_total_time': 100,
                     'Host_maintenance_end': 11,
+                    'Host_maintenance_start': 4,
                 },
                 timestamp=0,
             ),
@@ -1317,7 +1335,9 @@ def testMaintenanceEventTriggerAppendSamplesWithRegressionOutsideMaintenanceWind
     samples = [s]
     self.trigger.trigger_time = datetime.datetime.fromtimestamp(4)
     self.trigger.WaitForDisruption.return_value = [
-        base_disruption_trigger.DisruptionEvent(total_time=100, end_time=8)
+        base_disruption_trigger.DisruptionEvent(
+            total_time=100, end_time=8, start_time=4
+        )
     ]
     self.trigger.AppendSamples(None, vm_spec, samples)
     # Assertions
@@ -1347,6 +1367,7 @@ def testMaintenanceEventTriggerAppendSamplesWithRegressionOutsideMaintenanceWind
                     'random': 'random',
                     'LM_total_time': 100,
                     'Host_maintenance_end': 8,
+                    'Host_maintenance_start': 4,
                 },
                 timestamp=0,
             ),

tests/time_triggers/maintenance_simulation_trigger_test.py

@@ -87,7 +87,11 @@ def testWaitForDisruption(self):
                 'LM Total Time',
                 10,
                 'seconds',
-                {'LM_total_time': 10.0, 'Host_maintenance_end': 0.0},
+                {
+                    'LM_total_time': 10.0,
+                    'Host_maintenance_end': 0.0,
+                    'Host_maintenance_start': 0.0,
+                },
                 timestamp=0,
             )
         ],