fix: correct service.tf conditional for adk_live and upgrade Node.js to 20 (#692)

* fix: correct service.tf conditional for adk_live and upgrade Node.js to 20

- Fix service.tf exclusion to only apply when adk_live AND agent_engine
- Previously excluded service.tf for all adk_live deployments including cloud_run
- Upgrade Node.js from deprecated 18.x to 20.x LTS in Dockerfile and docs workflow

* refactor: extract shared lambda for service.tf conditional

DRY up the repeated lambda by defining _exclude_adk_live_agent_engine helper.

Author: eliasecchig

.github/workflows/docs.yml

@@ -27,7 +27,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: docs/package-lock.json
 

agent_starter_pack/cli/utils/template.py

@@ -89,6 +89,11 @@ def resolve_agent_alias(name: str | None) -> str | None:
 # The config dict contains: agent_name, cicd_runner, is_adk, is_adk_live, is_a2a
 # =============================================================================
 
+# Helper: exclude service.tf only for adk_live + agent_engine combination
+_exclude_adk_live_agent_engine = lambda c: not (
+    c.get("agent_name") == "adk_live" and c.get("deployment_target") == "agent_engine"
+)
+
 CONDITIONAL_FILES = {
     # CI/CD runner conditional files (base_template)
     ".cloudbuild": lambda c: c.get("cicd_runner") == "google_cloud_build",
@@ -108,10 +113,8 @@ def resolve_agent_alias(name: str | None) -> str | None:
     # Agent Engine deployment target conditionals
     "{agent_directory}/app_utils/expose_app.py": lambda c: c.get("is_adk_live"),
     "tests/helpers.py": lambda c: c.get("is_a2a"),
-    "deployment/terraform/service.tf": (lambda c: c.get("agent_name") != "adk_live"),
-    "deployment/terraform/dev/service.tf": (
-        lambda c: c.get("agent_name") != "adk_live"
-    ),
+    "deployment/terraform/service.tf": _exclude_adk_live_agent_engine,
+    "deployment/terraform/dev/service.tf": _exclude_adk_live_agent_engine,
 }
 
 

agent_starter_pack/deployment_targets/cloud_run/python/Dockerfile

@@ -20,7 +20,7 @@ RUN pip install --no-cache-dir uv==0.8.13
 # Install Node.js for frontend build
 RUN apt-get update && apt-get install -y \
     curl \
-    && curl -fsSL https://deb.nodesource.com/setup_18.x | bash - \
+    && curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \
     && apt-get install -y nodejs \
     && apt-get clean \
     && rm -rf /var/lib/apt/lists/*