check if new pytest-asyncio version is causing the flake

Author: rhatgadkar-goog

google/cloud/alloydbconnector/connector.py

@@ -383,23 +383,14 @@ def close(self) -> None:
                 self.close_async(), loop=self._loop
             )
             # Will attempt to gracefully shut down tasks for 3s
-            print("RISHABH DEBUG: before calling close_async()")
             close_future.result(timeout=3)
-        else:
-            print("RISHABH DEBUG: loop is not running 1")
         # if background thread exists for Connector, clean it up
         if self._thread.is_alive():
             if self._loop.is_running():
                 # stop event loop running in background thread
-                print("RISHABH DEBUG: before calling call_soon_threadsafe()")
                 self._loop.call_soon_threadsafe(self._loop.stop)
-            else:
-                print("RISHABH DEBUG: loop is not running 2")
             # wait for thread to finish closing (i.e. loop to stop)
-            print("RISHABH DEBUG: before calling thread.join()")
             self._thread.join()
-        else:
-            print("RISHABH DEBUG: thread is not alive")
         self._closed = True
 
     async def close_async(self) -> None:

requirements-test.txt

@@ -11,7 +11,10 @@ psycopg2-binary==2.9.9; python_version == "3.9" and sys_platform == "darwin"
 psycopg2-binary==2.9.10; python_version != "3.9" or sys_platform != "darwin"
 
 pytest==8.4.0
-pytest-asyncio==1.0.0
+
+pytest-asyncio==0.26.0; python_version == "3.9" and sys_platform == "win32"
+pytest-asyncio==1.0.0; python_version != "3.9" or sys_platform != "win32"
+
 pytest-cov==6.1.1
 pytest-aiohttp==1.1.0
 SQLAlchemy[asyncio]==2.0.41

tests/unit/test_connector.py

@@ -241,8 +241,6 @@ def test_Connector_close_called_multiple_times(credentials: FakeCredentials) ->
     # check that connector thread is no longer running
     assert connector._thread.is_alive() is False
     # call connector.close a second time
-    assert connector._loop.is_running() is False
-    print("RISHABH DEBUG: before calling close() a second time")
     connector.close()