Refactor check_build.sh to use Copybara for initial file setup, using gemini to fix all warnings seen previously about incorrect non fatal configuration setup.

PiperOrigin-RevId: 848213925
Change-Id: If88c9a10164e5f6fcd2444bfb2551e1d9e381e1b

Author: ludoch

api_dev/src/main/java/com/google/appengine/tools/info/Jetty121EE11Sdk.java

@@ -221,7 +221,7 @@ protected List<File> getJetty121Jars(String subDir) {
             || f.getName().contains("jakarta.interceptor")
             || f.getName().contains("jakarta.servlet-api-6.0.0") // for EE10
             || f.getName().contains("jakarta.transaction")
-            // TODO(ludo) Still needed for EE11, not sure why
+            // TODO Still needed for EE11, not sure why
             // || f.getName().contains("jetty-servlet-api-") // no javax.
             || f.getName().contains("ee8") // we want ee11 only. jakarta apis should be in shared
             || f.getName().contains("ee9") // we want ee11 only. jakarta apis should be in shared

appengine_jsr107/pom.xml

@@ -58,8 +58,7 @@
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
-            <artifactId>mockito-all</artifactId>
-            <version>1.10.19</version>
+            <artifactId>mockito-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>

appengine_testing_tests/pom.xml

@@ -55,8 +55,7 @@
 
         <dependency>
             <groupId>org.mockito</groupId>
-            <artifactId>mockito-all</artifactId>
-            <version>1.10.19</version>
+            <artifactId>mockito-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>

applications/guestbook/pom.xml

@@ -54,7 +54,6 @@
         <dependency>
             <groupId>javax.servlet</groupId>
             <artifactId>javax.servlet-api</artifactId>
-            <version>3.1.0</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
@@ -67,13 +66,11 @@
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
-            <version>4.13.2</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
-            <artifactId>mockito-all</artifactId>
-            <version>2.0.2-beta</version>
+            <artifactId>mockito-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>

applications/guestbook_jakarta/pom.xml

@@ -54,7 +54,6 @@
         <dependency>
             <groupId>jakarta.servlet</groupId>
             <artifactId>jakarta.servlet-api</artifactId>
-            <version>6.0.0</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
@@ -67,13 +66,11 @@
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
-            <version>4.13.2</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
-            <artifactId>mockito-all</artifactId>
-            <version>2.0.2-beta</version>
+            <artifactId>mockito-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>

applications/proberapp/pom.xml

@@ -133,7 +133,6 @@
         <dependency>
             <groupId>com.google.cloud</groupId>
             <artifactId>google-cloud-logging</artifactId>
-            <version>3.23.9</version>
         </dependency>
         <dependency>
             <groupId>com.google.cloud</groupId>
@@ -162,7 +161,6 @@
         <dependency>
             <groupId>javax.servlet</groupId>
             <artifactId>javax.servlet-api</artifactId>
-            <version>3.1.0</version>
         </dependency>
         <dependency>
             <groupId>junit</groupId>
@@ -177,28 +175,23 @@
         <dependency>
             <groupId>org.apache.httpcomponents</groupId>
             <artifactId>httpclient</artifactId>
-            <version>4.5.14</version>
         </dependency>
         <dependency>
             <groupId>org.apache.httpcomponents</groupId>
             <artifactId>httpcore</artifactId>
-            <version>4.4.16</version>
         </dependency>
         <dependency>
             <groupId>org.apache.httpcomponents</groupId>
             <artifactId>httpmime</artifactId>
-            <version>4.5.14</version>
         </dependency>
         <dependency>
             <groupId>com.google.http-client</groupId>
             <artifactId>google-http-client-jackson</artifactId>
-            <version>1.29.2</version>
         </dependency>
         <!-- Test Dependencies -->
         <dependency>
             <groupId>org.mockito</groupId>
-            <artifactId>mockito-all</artifactId>
-            <version>2.0.2-beta</version>
+            <artifactId>mockito-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>

applications/proberapp/src/main/java/app/ProberApp.java

@@ -970,7 +970,7 @@ private static void testMail(HttpServletRequest request) throws Exception {
     mailService.send(
         new MailService.Message(
             sender, "[email protected]", "java-prober-test-subject", "java-prober-test-textbody"));
-    // TODO(jihuinie): decide if we want to test sendToAdmins() in probers
+    // TODO: decide if we want to test sendToAdmins() in probers
     // mailService.sendToAdmins(
     //     new MailService.Message(sender, /* to= */ null, "test-subject", "test-textbody"));
   }
@@ -1161,7 +1161,7 @@ private static HttpResponse uploadFileToUrl(String uploadName, String filepath,
     // The SSL certificate in GAE QA environment doesn't include `uc.r.prom-qa.sandbox.google.com`,
     // and this blocks the QA app from sending HTTP request to itself. We need to suppress the cert
     // validation in QA for now.
-    // TODO(jihuinie): remove when b/190648760 is fixed.
+    // TODO: remove when b/190648760 is fixed.
     if (isRunningInQa()) {
       httpClient = makeHttpClientWithoutSslValidation();
     }

applications/servletasyncapp/pom.xml

@@ -43,7 +43,6 @@
         <dependency>
             <groupId>javax.servlet</groupId>
             <artifactId>javax.servlet-api</artifactId>
-            <version>3.1.0</version>
             <scope>provided</scope>
         </dependency>
     </dependencies>

applications/servletasyncappjakarta/pom.xml

@@ -43,7 +43,6 @@
         <dependency>
             <groupId>jakarta.servlet</groupId>
             <artifactId>jakarta.servlet-api</artifactId>
-            <version>6.0.0</version>
             <scope>provided</scope>
         </dependency>
     </dependencies>

applications/springboot/pom.xml

@@ -65,7 +65,6 @@
         <dependency>
             <groupId>jakarta.servlet</groupId>
             <artifactId>jakarta.servlet-api</artifactId>
-            <version>6.1.0</version>
             <scope>provided</scope>
         </dependency>