Skip to content

Commit 392ff4d

Browse files
ci: remove secret manager secrets from unit tests (#2052)
1 parent a411110 commit 392ff4d

File tree

1 file changed

+2
-41
lines changed

1 file changed

+2
-41
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -50,55 +50,16 @@ jobs:
5050

5151
- id: auth
5252
name: Authenticate to Google Cloud
53+
# only needed for Flakybot on periodic (schedule) and continuous (push) events
54+
if: ${{ github.event_name == 'schedule' || github.event_name == 'push' }}
5355
uses: google-github-actions/auth@71fee32a0bb7e97b4d33d548e7d957010649d8fa # v2.1.3
5456
with:
5557
workload_identity_provider: ${{ vars.PROVIDER_NAME }}
5658
service_account: ${{ vars.SERVICE_ACCOUNT }}
5759
access_token_lifetime: 600s
5860

59-
- id: secrets
60-
name: Get secrets
61-
uses: google-github-actions/get-secretmanager-secrets@dc4a1392bad0fd60aee00bb2097e30ef07a1caae # v2.1.3
62-
with:
63-
secrets: |-
64-
MYSQL_CONNECTION_NAME:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_CONNECTION_NAME
65-
MYSQL_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_USER
66-
MYSQL_IAM_CONNECTION_NAME:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_JAVA_IAM_CONNECTION_NAME
67-
MYSQL_IAM_USER_JAVA:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_USER_IAM_JAVA
68-
MYSQL_PASS:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_PASS
69-
MYSQL_DB:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_DB
70-
POSTGRES_CONNECTION_NAME:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_CONNECTION_NAME
71-
POSTGRES_IAM_CONNECTION_NAME:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_IAM_CONNECTION_NAME
72-
POSTGRES_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_USER
73-
POSTGRES_IAM_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_USER_IAM_JAVA
74-
POSTGRES_PASS:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_PASS
75-
POSTGRES_DB:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_DB
76-
SQLSERVER_CONNECTION_NAME:${{ vars.GOOGLE_CLOUD_PROJECT }}/SQLSERVER_CONNECTION_NAME
77-
SQLSERVER_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/SQLSERVER_USER
78-
SQLSERVER_PASS:${{ vars.GOOGLE_CLOUD_PROJECT }}/SQLSERVER_PASS
79-
SQLSERVER_DB:${{ vars.GOOGLE_CLOUD_PROJECT }}/SQLSERVER_DB
80-
IMPERSONATED_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/IMPERSONATED_USER
81-
QUOTA_PROJECT:${{ vars.GOOGLE_CLOUD_PROJECT }}/QUOTA_PROJECT
8261
- name: Run tests
8362
env:
84-
MYSQL_CONNECTION_NAME: "${{ steps.secrets.outputs.MYSQL_CONNECTION_NAME }}"
85-
MYSQL_USER: "${{ steps.secrets.outputs.MYSQL_USER }}"
86-
MYSQL_IAM_CONNECTION_NAME: "${{ steps.secrets.outputs.MYSQL_IAM_CONNECTION_NAME }}"
87-
MYSQL_IAM_USER: "${{ steps.secrets.outputs.MYSQL_IAM_USER_JAVA }}"
88-
MYSQL_PASS: "${{ steps.secrets.outputs.MYSQL_PASS }}"
89-
MYSQL_DB: "${{ steps.secrets.outputs.MYSQL_DB }}"
90-
POSTGRES_CONNECTION_NAME: "${{ steps.secrets.outputs.POSTGRES_CONNECTION_NAME }}"
91-
POSTGRES_IAM_CONNECTION_NAME: "${{ steps.secrets.outputs.POSTGRES_IAM_CONNECTION_NAME }}"
92-
POSTGRES_USER: "${{ steps.secrets.outputs.POSTGRES_USER }}"
93-
POSTGRES_IAM_USER: "${{ steps.secrets.outputs.POSTGRES_IAM_USER }}"
94-
POSTGRES_PASS: "${{ steps.secrets.outputs.POSTGRES_PASS }}"
95-
POSTGRES_DB: "${{ steps.secrets.outputs.POSTGRES_DB }}"
96-
SQLSERVER_CONNECTION_NAME: "${{ steps.secrets.outputs.SQLSERVER_CONNECTION_NAME }}"
97-
SQLSERVER_USER: "${{ steps.secrets.outputs.SQLSERVER_USER }}"
98-
SQLSERVER_PASS: "${{ steps.secrets.outputs.SQLSERVER_PASS }}"
99-
SQLSERVER_DB: "${{ steps.secrets.outputs.SQLSERVER_DB }}"
100-
IMPERSONATED_USER: "${{ steps.secrets.outputs.IMPERSONATED_USER }}"
101-
QUOTA_PROJECT: "${{ steps.secrets.outputs.QUOTA_PROJECT }}"
10263
JOB_TYPE: test
10364
run: ./.github/scripts/run_tests.sh
10465
shell: bash

0 commit comments

Comments
 (0)