Skip to content

Commit ee55b2c

Browse files
joaoandremartinskurtisvg
authored andcommitted
Correctly sets user agent (#79)
1 parent fb7c274 commit ee55b2c

File tree

2 files changed

+5
-63
lines changed

2 files changed

+5
-63
lines changed

core/src/main/java/com/google/cloud/sql/core/SslSocketFactory.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -140,14 +140,9 @@ public static synchronized SslSocketFactory getInstance() {
140140
credentialFactory = new ApplicationDefaultCredentialFactory();
141141
}
142142

143-
String userToken = System.getProperty(USER_TOKEN_PROPERTY_NAME);
144143
Credential credential = credentialFactory.create();
145144

146-
HttpRequestInitializer requestInitializer = userToken == null
147-
? credential
148-
: new UsageMetricsHttpRequestInterceptor(credential, userToken);
149-
150-
SQLAdmin adminApi = createAdminApiClient(requestInitializer);
145+
SQLAdmin adminApi = createAdminApiClient(credential);
151146
sslSocketFactory =
152147
new SslSocketFactory(
153148
new Clock(), keyPair, credential, adminApi, DEFAULT_SERVER_PROXY_PORT);
@@ -532,11 +527,14 @@ private static SQLAdmin createAdminApiClient(HttpRequestInitializer requestIniti
532527

533528
String rootUrl = System.getProperty(API_ROOT_URL_PROPERTY);
534529
String servicePath = System.getProperty(API_SERVICE_PATH_PROPERTY);
530+
String userToken = System.getProperty(USER_TOKEN_PROPERTY_NAME);
535531

536532
JsonFactory jsonFactory = JacksonFactory.getDefaultInstance();
537533
SQLAdmin.Builder adminApiBuilder =
538534
new Builder(httpTransport, jsonFactory, requestInitializer)
539-
.setApplicationName("Cloud SQL Java Socket Factory");
535+
.setApplicationName(userToken != null
536+
? userToken
537+
: "Cloud SQL Java Socket Factory");
540538
if (rootUrl != null) {
541539
logTestPropertyWarning(API_ROOT_URL_PROPERTY);
542540
adminApiBuilder.setRootUrl(rootUrl);

core/src/main/java/com/google/cloud/sql/core/UsageMetricsHttpRequestInterceptor.java

Lines changed: 0 additions & 56 deletions
This file was deleted.

0 commit comments

Comments
 (0)