feat: Support dns name for connector names #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
gh-683-dns-names
branch
4 times, most recently
from
f766f7a to
86e7687
Compare
kgala2
approved these changes
Aug 26, 2025
Adds test cases to demonstrate that the DNS name may be used for the instance connection name for instances with DNS TXT records. Fixes #683
hessjcg
force-pushed
the
gh-683-dns-names
branch
from
86e7687 to
c9a17a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test cases to demonstrate that the DNS name may be used for the instance connection name for instances with DNS TXT records.
Fixes #683