feat: Add MySQL caching_sha2_password support for the proxy clients using unix sockets. (#2489)

hessjcg · web-flow · commit 6ff8753f486e · 2025-10-29T14:56:03.000-06:00
Automatically set the MDX client_protocol_type field to "TCP" or "UDS" for mysql instances that support Metadata Exchange. This will ensure that password login works correctly in MySQL 8.0 or higher when the user has a caching_sha2_password. We will leave this in a draft state until back-end support for this is fully rolled out. Fixes #2317
diff --git a/internal/proxy/fuse.go b/internal/proxy/fuse.go
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 //go:build !windows && !openbsd && !freebsd
-// +build !windows,!openbsd,!freebsd
 
 package proxy
 
diff --git a/internal/proxy/fuse_test.go b/internal/proxy/fuse_test.go
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 //go:build !windows && !darwin
-// +build !windows,!darwin
 
 package proxy_test
 
diff --git a/internal/proxy/proxy.go b/internal/proxy/proxy.go
@@ -297,6 +297,11 @@ func dialOptions(c Config, i InstanceConnConfig) []cloudsqlconn.DialOption {
 	default:
 		// assume public IP by default
 	}
+	if networkType(&c, i) == "unix" {
+		opts = append(opts, cloudsqlconn.WithMdxClientProtocolType("uds"))
+	} else {
+		opts = append(opts, cloudsqlconn.WithMdxClientProtocolType("tcp"))
+	}
 
 	return opts
 }
diff --git a/internal/proxy/proxy_other.go b/internal/proxy/proxy_other.go
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 //go:build !windows && !openbsd && !freebsd
-// +build !windows,!openbsd,!freebsd
 
 package proxy
 
diff --git a/internal/proxy/proxy_other_test.go b/internal/proxy/proxy_other_test.go
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 //go:build !windows
-// +build !windows
 
 package proxy_test
 
diff --git a/internal/proxy/unix.go b/internal/proxy/unix.go
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 //go:build !windows
-// +build !windows
 
 package proxy
 
diff --git a/main.go b/main.go
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 //go:build !windows
-// +build !windows
 
 package main
 

Original file line number	Diff line number	Diff line change
`@@ -297,6 +297,11 @@ func dialOptions(c Config, i InstanceConnConfig) []cloudsqlconn.DialOption {`
`297`	`297`	`default:`
`298`	`298`	`// assume public IP by default`
`299`	`299`	`}`
	`300`	`+ if networkType(&c, i) == "unix" {`
	`301`	`+ opts = append(opts, cloudsqlconn.WithMdxClientProtocolType("uds"))`
	`302`	`+ } else {`
	`303`	`+ opts = append(opts, cloudsqlconn.WithMdxClientProtocolType("tcp"))`
	`304`	`+ }`
`300`	`305`
`301`	`306`	`return opts`
`302`	`307`	`}`