chore: update region tags in test samples (#396)

Author: jackwotherspoon

tests/system/test_connector_object.py

@@ -36,11 +36,11 @@ def getconn() -> pymysql.connections.Connection:
         )
         return conn
 
-    engine = sqlalchemy.create_engine(
+    pool = sqlalchemy.create_engine(
         "mysql+pymysql://",
         creator=getconn,
     )
-    return engine
+    return pool
 
 
 def test_connector_with_credentials() -> None:

tests/system/test_ip_types.py

@@ -38,11 +38,11 @@ def getconn() -> pymysql.connections.Connection:
         )
         return conn
 
-    engine = sqlalchemy.create_engine(
+    pool = sqlalchemy.create_engine(
         "mysql+pymysql://",
         creator=getconn,
     )
-    return engine
+    return pool
 
 
 def test_public_ip() -> None:

tests/system/test_pg8000_connection.py

@@ -17,11 +17,15 @@
 import uuid
 from typing import Generator
 
-import pg8000
 import pytest
+
+# [START cloud_sql_connector_postgres_pg8000]
+import pg8000
 import sqlalchemy
 from google.cloud.sql.connector import Connector
 
+# [END cloud_sql_connector_postgres_pg8000]
+
 table_name = f"books_{uuid.uuid4().hex}"
 
 
@@ -30,6 +34,7 @@
 # 'creator' argument to 'create_engine'
 def init_connection_engine() -> sqlalchemy.engine.Engine:
     def getconn() -> pg8000.dbapi.Connection:
+        # initialize Connector object for connections to Cloud SQL
         with Connector() as connector:
             conn: pg8000.dbapi.Connection = connector.connect(
                 os.environ["POSTGRES_CONNECTION_NAME"],
@@ -40,12 +45,13 @@ def getconn() -> pg8000.dbapi.Connection:
             )
             return conn
 
-    engine = sqlalchemy.create_engine(
+    # create SQLAlchemy connection pool
+    pool = sqlalchemy.create_engine(
         "postgresql+pg8000://",
         creator=getconn,
     )
-    engine.dialect.description_encoding = None
-    return engine
+    pool.dialect.description_encoding = None
+    return pool
 
 
 # [END cloud_sql_connector_postgres_pg8000]

tests/system/test_pg8000_iam_auth.py

@@ -17,18 +17,22 @@
 import uuid
 from typing import Generator
 
-import pg8000
+# [START cloud_sql_connector_postgres_pg8000_iam_auth]
 import pytest
+import pg8000
 import sqlalchemy
 from google.cloud.sql.connector import Connector
 
+# [END cloud_sql_connector_postgres_pg8000_iam_auth]
+
 table_name = f"books_{uuid.uuid4().hex}"
 
 
 # [START cloud_sql_connector_postgres_pg8000_iam_auth]
 # The Cloud SQL Python Connector can be used along with SQLAlchemy using the
 # 'creator' argument to 'create_engine'
 def init_connection_engine() -> sqlalchemy.engine.Engine:
+    # initialize Connector object for connections to Cloud SQL
     def getconn() -> pg8000.dbapi.Connection:
         with Connector() as connector:
             conn: pg8000.dbapi.Connection = connector.connect(
@@ -40,12 +44,13 @@ def getconn() -> pg8000.dbapi.Connection:
             )
             return conn
 
-    engine = sqlalchemy.create_engine(
+    # create SQLAlchemy connection pool
+    pool = sqlalchemy.create_engine(
         "postgresql+pg8000://",
         creator=getconn,
     )
-    engine.dialect.description_encoding = None
-    return engine
+    pool.dialect.description_encoding = None
+    return pool
 
 
 # [END cloud_sql_connector_postgres_pg8000_iam_auth]

tests/system/test_pymysql_connection.py

@@ -17,11 +17,15 @@
 import uuid
 from typing import Generator
 
-import pymysql
 import pytest
+
+# [START cloud_sql_connector_mysql_pymysql]
+import pymysql
 import sqlalchemy
 from google.cloud.sql.connector import Connector
 
+# [END cloud_sql_connector_mysql_pymysql]
+
 table_name = f"books_{uuid.uuid4().hex}"
 
 
@@ -30,6 +34,7 @@
 # 'creator' argument to 'create_engine'
 def init_connection_engine() -> sqlalchemy.engine.Engine:
     def getconn() -> pymysql.connections.Connection:
+        # initialize Connector object for connections to Cloud SQL
         with Connector() as connector:
             conn: pymysql.connections.Connection = connector.connect(
                 os.environ["MYSQL_CONNECTION_NAME"],
@@ -40,11 +45,12 @@ def getconn() -> pymysql.connections.Connection:
             )
             return conn
 
-    engine = sqlalchemy.create_engine(
+    # create SQLAlchemy connection pool
+    pool = sqlalchemy.create_engine(
         "mysql+pymysql://",
         creator=getconn,
     )
-    return engine
+    return pool
 
 
 # [END cloud_sql_connector_mysql_pymysql]

tests/system/test_pytds_connection.py

@@ -17,11 +17,15 @@
 import uuid
 from typing import Generator
 
-import pytds
 import pytest
+
+# [START cloud_sql_connector_mysql_pytds]
+import pytds
 import sqlalchemy
 from google.cloud.sql.connector import Connector
 
+# [END cloud_sql_connector_mysql_pytds]
+
 table_name = f"books_{uuid.uuid4().hex}"
 
 
@@ -31,6 +35,7 @@
 # 'sqlalchemy-pytds` in your dependencies
 def init_connection_engine() -> sqlalchemy.engine.Engine:
     def getconn() -> pytds.Connection:
+        # initialize Connector object for connections to Cloud SQL
         with Connector() as connector:
             conn = connector.connect(
                 os.environ["SQLSERVER_CONNECTION_NAME"],
@@ -41,12 +46,13 @@ def getconn() -> pytds.Connection:
             )
             return conn
 
-    engine = sqlalchemy.create_engine(
+    # create SQLAlchemy connection pool
+    pool = sqlalchemy.create_engine(
         "mssql+pytds://localhost",
         creator=getconn,
     )
-    engine.dialect.description_encoding = None
-    return engine
+    pool.dialect.description_encoding = None
+    return pool
 
 
 # [END cloud_sql_connector_mysql_pytds]