Skip to content

Commit f6fdb84

Browse files
committed
chore(csql): update instance secrets for tests
1 parent 1cbfb1c commit f6fdb84

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
MYSQL_IAM_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_USER_IAM_PYTHON
7373
MYSQL_PASS:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_PASS
7474
MYSQL_DB:${{ vars.GOOGLE_CLOUD_PROJECT }}/MYSQL_DB
75-
POSTGRES_IAM_CONNECTION_NAME:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_IAM_CONNECTION_NAME
75+
POSTGRES_CONNECTION_NAME:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_CONNECTION_NAME
7676
POSTGRES_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_USER
7777
POSTGRES_IAM_USER:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_USER_IAM_PYTHON
7878
POSTGRES_PASS:${{ vars.GOOGLE_CLOUD_PROJECT }}/POSTGRES_PASS
@@ -93,7 +93,7 @@ jobs:
9393
MYSQL_IAM_USER: "${{ steps.secrets.outputs.MYSQL_IAM_USER }}"
9494
MYSQL_PASS: "${{ steps.secrets.outputs.MYSQL_PASS }}"
9595
MYSQL_DB: "${{ steps.secrets.outputs.MYSQL_DB }}"
96-
POSTGRES_IAM_CONNECTION_NAME: "${{ steps.secrets.outputs.POSTGRES_IAM_CONNECTION_NAME }}"
96+
POSTGRES_CONNECTION_NAME: "${{ steps.secrets.outputs.POSTGRES_CONNECTION_NAME }}"
9797
POSTGRES_USER: "${{ steps.secrets.outputs.POSTGRES_USER }}"
9898
POSTGRES_IAM_USER: "${{ steps.secrets.outputs.POSTGRES_IAM_USER }}"
9999
POSTGRES_PASS: "${{ steps.secrets.outputs.POSTGRES_PASS }}"

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export POSTGRES_PASS="db_pass"
7373
export POSTGRES_DB="db_name"
7474
# Postgres instance with IAM authentication enabled
7575
# (can be same as POSTGRES_CONNECTION_NAME)
76-
export POSTGRES_IAM_CONNECTION_NAME="<PROJECT>:<REGION>:<INSTANCE>"
76+
export POSTGRES_CONNECTION_NAME="<PROJECT>:<REGION>:<INSTANCE>"
7777
# IAM Principal of ADC sourced credentials
7878
export POSTGRES_IAM_USER="[email protected]"
7979

tests/system/test_asyncpg_connection.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,8 @@ async def getconn(
151151

152152
async def test_sqlalchemy_connection_with_asyncpg() -> None:
153153
"""Basic test to get time from database."""
154-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
155-
user = os.environ["POSTGRES_IAM_USER"]
154+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
155+
user = os.environ["POSTGRES_USER"]
156156
password = os.environ["POSTGRES_PASS"]
157157
db = os.environ["POSTGRES_DB"]
158158

@@ -167,8 +167,8 @@ async def test_sqlalchemy_connection_with_asyncpg() -> None:
167167

168168
async def test_lazy_sqlalchemy_connection_with_asyncpg() -> None:
169169
"""Basic test to get time from database."""
170-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
171-
user = os.environ["POSTGRES_IAM_USER"]
170+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
171+
user = os.environ["POSTGRES_USER"]
172172
password = os.environ["POSTGRES_PASS"]
173173
db = os.environ["POSTGRES_DB"]
174174

@@ -185,8 +185,8 @@ async def test_lazy_sqlalchemy_connection_with_asyncpg() -> None:
185185

186186
async def test_connection_with_asyncpg() -> None:
187187
"""Basic test to get time from database."""
188-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
189-
user = os.environ["POSTGRES_IAM_USER"]
188+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
189+
user = os.environ["POSTGRES_USER"]
190190
password = os.environ["POSTGRES_PASS"]
191191
db = os.environ["POSTGRES_DB"]
192192

@@ -201,8 +201,8 @@ async def test_connection_with_asyncpg() -> None:
201201

202202
async def test_lazy_connection_with_asyncpg() -> None:
203203
"""Basic test to get time from database."""
204-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
205-
user = os.environ["POSTGRES_IAM_USER"]
204+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
205+
user = os.environ["POSTGRES_USER"]
206206
password = os.environ["POSTGRES_PASS"]
207207
db = os.environ["POSTGRES_DB"]
208208

tests/system/test_asyncpg_iam_auth.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ async def getconn() -> asyncpg.Connection:
8686

8787
async def test_iam_authn_connection_with_asyncpg() -> None:
8888
"""Basic test to get time from database."""
89-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
89+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
9090
user = os.environ["POSTGRES_IAM_USER"]
9191
db = os.environ["POSTGRES_DB"]
9292

@@ -101,7 +101,7 @@ async def test_iam_authn_connection_with_asyncpg() -> None:
101101

102102
async def test_lazy_iam_authn_connection_with_asyncpg() -> None:
103103
"""Basic test to get time from database."""
104-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
104+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
105105
user = os.environ["POSTGRES_IAM_USER"]
106106
db = os.environ["POSTGRES_DB"]
107107

tests/system/test_pg8000_connection.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ def getconn() -> pg8000.dbapi.Connection:
9191

9292
def test_pg8000_connection() -> None:
9393
"""Basic test to get time from database."""
94-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
95-
user = os.environ["POSTGRES_IAM_USER"]
94+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
95+
user = os.environ["POSTGRES_USER"]
9696
password = os.environ["POSTGRES_PASS"]
9797
db = os.environ["POSTGRES_DB"]
9898

@@ -107,8 +107,8 @@ def test_pg8000_connection() -> None:
107107

108108
def test_lazy_pg8000_connection() -> None:
109109
"""Basic test to get time from database."""
110-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
111-
user = os.environ["POSTGRES_IAM_USER"]
110+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
111+
user = os.environ["POSTGRES_USER"]
112112
password = os.environ["POSTGRES_PASS"]
113113
db = os.environ["POSTGRES_DB"]
114114

tests/system/test_pg8000_iam_auth.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def getconn() -> pg8000.dbapi.Connection:
8484

8585
def test_pg8000_iam_authn_connection() -> None:
8686
"""Basic test to get time from database."""
87-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
87+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
8888
user = os.environ["POSTGRES_IAM_USER"]
8989
db = os.environ["POSTGRES_DB"]
9090

@@ -99,7 +99,7 @@ def test_pg8000_iam_authn_connection() -> None:
9999

100100
def test_lazy_pg8000_iam_authn_connection() -> None:
101101
"""Basic test to get time from database."""
102-
inst_conn_name = os.environ["POSTGRES_IAM_CONNECTION_NAME"]
102+
inst_conn_name = os.environ["POSTGRES_CONNECTION_NAME"]
103103
user = os.environ["POSTGRES_IAM_USER"]
104104
db = os.environ["POSTGRES_DB"]
105105

0 commit comments

Comments
 (0)