- 
                Notifications
    You must be signed in to change notification settings 
- Fork 83
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
User agent currently is set during the first connection call. Subsequent calls have no way of updating the custom user agent. Aka if you create a connector and use it with many drivers or many custom user agents only the ones used on the first connect will be set.
Instead we should keep a set() of user agents and add as we go and update the client.
cloud-sql-python-connector/google/cloud/sql/connector/connector.py
Lines 215 to 220 in bb04427
| self._client = CloudSQLClient( | |
| self._sqladmin_api_endpoint, | |
| self._quota_project, | |
| self._credentials, | |
| user_agent=self._user_agent, | |
| driver=driver, | 
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.