Skip to content

Conversation

@kgala2
Copy link
Collaborator

@kgala2 kgala2 commented Mar 31, 2025

Adds schedule reporter workflow action that runs daily to go through builds on Cloud Build and create/update failing tests issues

@kgala2 kgala2 marked this pull request as ready for review April 1, 2025 17:40
@kgala2 kgala2 requested a review from a team as a code owner April 1, 2025 17:40
@kgala2 kgala2 requested a review from jackwotherspoon April 1, 2025 17:40
@jackwotherspoon
Copy link
Collaborator

This needs to be rebased I believe...

@jackwotherspoon jackwotherspoon changed the title build: add schedule reporter and cb failure reporter files ci: add schedule reporter and cb failure reporter files Apr 1, 2025
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgala2 What is the plan to test that this works?

@kgala2
Copy link
Collaborator Author

kgala2 commented Apr 2, 2025

@kgala2 What is the plan to test that this works?

I will on purpose break one of the system tests to monitor this for 2 days

@jackwotherspoon
Copy link
Collaborator

I will on purpose break one of the system tests to monitor this for 2 days

@kgala2 Can you explain your thinking a little bit?

We do not want to push broken tests to our main branch...

An alternative solution off the top of my head would be to do the following:

  • Add a placeholder to schedule_reporter.yml trigger names with something like manual-test-trigger
  • Add a manual build trigger
  • Add a test that asserts a failure to your test branch and manually trigger a build. Wait and see if the reporting tool picks it up and creates an issue on its next run.
  • Put up a PR to remove the placeholder from schedule_reporter.yml once satisified

@jackwotherspoon
Copy link
Collaborator

On second thought, I guess you could do exactly what I said but with py-integration-test-nightly. You could just update the trigger to point at a test branch of yours with the simulated failure test and manually invoke the trigger. Then switch it back to point at main branch.

This would allow you to not need to use a placeholder trigger name.

@kgala2 kgala2 merged commit 72a0702 into main Apr 2, 2025
17 checks passed
@kgala2 kgala2 deleted the cb-reporter branch April 2, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants