test: update server used for tests to use SSL/TLS #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
changed the title
hessjcg
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the local server used for unit tests.
The previous
serverfixture was just a plain socket unable to perform SSL/TLS.This meant in certain tests we were skipping the SSL/TLS handshake because it
would fail.
The new
proxy_serverfixture more closely behaves to that of the real Proxy server.It allows SSL/TLS by loading in the server CA used for testing, the client can then
use the new
contextfixture to properly use SSL to connect to the server.This will provide a foundation for testing the metadata exchange which will be
introduced in the near future.