Skip to content
This repository was archived by the owner on Sep 14, 2022. It is now read-only.

Commit 35c3c49

Browse files
authored
Merge pull request #81 from ubschmidt/master
Simplify labels; use the global labels where possible, otherwise use the new prefix.
2 parents 9fb278b + b3bebe2 commit 35c3c49

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

guice/annotation/src/main/java/com/google/cloud/trace/guice/annotation/TracerSpanInterceptor.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,15 @@ public Object invoke(MethodInvocation invocation) throws Throwable {
5555

5656
if (span.callLabels() == Option.TRUE) {
5757
labelsBeforeCallBuilder
58-
.add("trace.cloud.google.com/call/class",
58+
.add("g.co/call/class",
5959
invocation.getMethod().getDeclaringClass().getName())
60-
.add("trace.cloud.google.com/call/method",
60+
.add("g.co/call/method",
6161
invocation.getMethod().getName())
62-
.add("trace.cloud.google.com/call/package",
62+
.add("g.co/call/package",
6363
invocation.getMethod().getDeclaringClass().getPackage().getName());
6464
}
6565
if (span.entry()) {
66-
labelsBeforeCallBuilder.add("trace.cloud.google.com/agent", "cloud-trace-java/0.1");
66+
labelsBeforeCallBuilder.add("/agent", "cloud-trace-java/0.1");
6767
}
6868

6969
String methodName;
@@ -124,8 +124,8 @@ public Object invoke(MethodInvocation invocation) throws Throwable {
124124
} catch (Throwable t) {
125125
if (span.callLabels() == Option.TRUE) {
126126
labelsAfterCallBuilder
127-
.add("trace.cloud.google.com/exception/class", t.getClass().getName())
128-
.add("trace.cloud.google.com/exception/message", t.getMessage());
127+
.add("g.co/exception/class", t.getClass().getName())
128+
.add("g.co/exception/message", t.getMessage());
129129
}
130130
} finally {
131131
if (stackTraceEnabled) {

sdk/servlet/src/main/java/com/google/cloud/trace/servlet/RequestLabelsHelper.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ public static String overrideName(HttpServletRequest request) {
4646
* @param labelsBuilder the labels builder to add span label annotations to.
4747
*/
4848
public static void addRequestLabels(HttpServletRequest request, Labels.Builder labelsBuilder) {
49-
labelsBuilder.add("trace.cloud.google.com/http/method", request.getMethod());
50-
labelsBuilder.add("trace.cloud.google.com/http/url", request.getRequestURL().toString());
49+
labelsBuilder.add("/http/method", request.getMethod());
50+
labelsBuilder.add("/http/url", request.getRequestURL().toString());
5151
if (request.getContentLength() != -1) {
5252
labelsBuilder.add(
53-
"trace.cloud.google.com/http/request/size", Integer.toString(request.getContentLength()));
53+
"/http/request/size", Integer.toString(request.getContentLength()));
5454
}
55-
labelsBuilder.add("trace.cloud.google.com/http/host", request.getServerName());
55+
labelsBuilder.add("/http/host", request.getServerName());
5656
if (request.getHeader("user-agent") != null) {
57-
labelsBuilder.add("trace.cloud.google.com/http/user_agent", request.getHeader("user-agent"));
57+
labelsBuilder.add("/http/user_agent", request.getHeader("user-agent"));
5858
}
5959
}
6060

@@ -66,11 +66,11 @@ public static void addRequestLabels(HttpServletRequest request, Labels.Builder l
6666
* @param labelsBuilder the labels builder to add span label annotations to.
6767
*/
6868
public static void addResponseLabels(HttpServletResponse response, Labels.Builder labelsBuilder) {
69-
// Add "trace.cloud.google.com/http/status_code" to Integer.toString(response.getStatus()), if
69+
// Add "/http/status_code" to Integer.toString(response.getStatus()), if
7070
// GAE supports 3.0.
7171
if (response.getBufferSize() > 0) {
7272
labelsBuilder.add(
73-
"trace.cloud.google.com/http/response/size", Integer.toString(response.getBufferSize()));
73+
"/http/response/size", Integer.toString(response.getBufferSize()));
7474
}
7575
}
7676
}

sinks/v1/sink/src/main/java/com/google/cloud/trace/v1/producer/TraceProducer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public Trace generateSetStackTrace(
159159
stackTraceValue.append("]}");
160160

161161
spanBuilder.putLabels(
162-
"trace.cloud.google.com/stacktrace", stackTraceValue.toString());
162+
"/stacktrace", stackTraceValue.toString());
163163

164164
Trace.Builder traceBuilder =
165165
Trace.newBuilder()

0 commit comments

Comments
 (0)