File tree Expand file tree Collapse file tree 1 file changed +9
-1
lines changed
Expand file tree Collapse file tree 1 file changed +9
-1
lines changed Original file line number Diff line number Diff line change @@ -45,7 +45,15 @@ Samples in this repository also follow the [framework coding
4545style] ( https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) .
4646This is enforced using [ CodeFormatter] ( https://github.com/dotnet/codeformatter ) .
4747
48- ### Starting a new sample
48+ ## Starting a new sample set
4949When starting a new sample, match the file and directory layout in the
5050[ KMS Samples] ( kms/api/Kms.Samples ) and [ KMS Samples Tests] ( kms/api/Kms.Samples.Tests ) . KMS samples and tests are
5151the canonical example of how samples in this repo should be structured.
52+
53+ ## PR size
54+ In general prefer small PRs over bigger ones. A good rule of thumb is, no more than 10 new/modified files per PR.
55+ This is particularly relevant when starting a new sample set, when all files are new.
56+
57+ - Reviews of smaller PRs are faster.
58+ - Time to merge is faster, both incrementally and overall.
59+ - Feedback and issues found in a first small PR can be more easily applied to subsequent small PRs.
You can’t perform that action at this time.
0 commit comments