Skip to content

Commit 7c3ba75

Browse files
authored
Replace URI decode with CGI unescape (#497)
1 parent 11c1413 commit 7c3ba75

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/plugin/base_test.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
require 'mocha/test_unit'
2222
require 'prometheus/client'
2323
require 'webmock/test_unit'
24+
require 'cgi'
2425

2526
require_relative 'asserts'
2627
require_relative 'constants'
@@ -823,7 +824,7 @@ def test_reject_non_utf8_container_name_with_require_valid_tags_true
823824
params = CONTAINER_FROM_METADATA_PARAMS.merge(
824825
labels: CONTAINER_FROM_METADATA_PARAMS[:labels].merge(
825826
"#{GKE_CONSTANTS[:service]}/container_name" =>
826-
URI.decode(encoded_name)),
827+
CGI.unescape(encoded_name)),
827828
log_name: encoded_name)
828829
verify_log_entries(0, params, 'textPayload')
829830
end
@@ -906,7 +907,7 @@ def test_sanitize_tags_from_container_name_with_require_valid_tags_false
906907
params = CONTAINER_FROM_METADATA_PARAMS.merge(
907908
resource: CONTAINER_FROM_METADATA_PARAMS[:resource].merge(
908909
labels: CONTAINER_FROM_METADATA_PARAMS[:resource][:labels].merge(
909-
'container_name' => URI.decode(encoded_container_name))),
910+
'container_name' => CGI.unescape(encoded_container_name))),
910911
log_name: encoded_container_name)
911912
verify_log_entries(1, params, 'textPayload')
912913
end

0 commit comments

Comments
 (0)