chore: Update lints, require Dart 3, allow latest pkg:http (#395)

Author: kevmoo

.github/workflows/lint.yml

@@ -1,4 +1,4 @@
-# Created with package:mono_repo v6.5.4
+# Created with package:mono_repo v6.5.6
 name: Dart Lint CI
 on:
   push:
@@ -35,27 +35,27 @@ jobs:
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
       - name: mono_repo self validate
-        run: dart pub global activate mono_repo 6.5.4
+        run: dart pub global activate mono_repo 6.5.6
       - name: mono_repo self validate
         run: dart pub global run mono_repo generate --validate
   job_002:
-    name: "analyze_format; Dart 2.18.0; PKGS: dartfn, functions_framework, functions_framework_builder, gcp; `dart analyze`"
+    name: "analyze_format; Dart 3.0.0; PKGS: dartfn, functions_framework, functions_framework_builder, gcp; `dart analyze`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:dartfn-functions_framework-functions_framework_builder-gcp;commands:analyze_1"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0;packages:dartfn-functions_framework-functions_framework_builder-gcp;commands:analyze_1"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:dartfn-functions_framework-functions_framework_builder-gcp
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0;packages:dartfn-functions_framework-functions_framework_builder-gcp
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.18.0"
+          sdk: "3.0.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab

.github/workflows/unit.yml

@@ -1,4 +1,4 @@
-# Created with package:mono_repo v6.5.4
+# Created with package:mono_repo v6.5.6
 name: Dart Unit CI
 on:
   push:
@@ -16,23 +16,23 @@ permissions: read-all
 
 jobs:
   job_001:
-    name: "unit_test; linux; Dart 2.18.0; PKGS: dartfn, functions_framework_builder, gcp, integration_test; `dart test`"
+    name: "unit_test; linux; Dart 3.0.0; PKGS: dartfn, functions_framework_builder, gcp, integration_test; `dart test`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:dartfn-functions_framework_builder-gcp-integration_test;commands:test_0"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0;packages:dartfn-functions_framework_builder-gcp-integration_test;commands:test_0"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:dartfn-functions_framework_builder-gcp-integration_test
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0;packages:dartfn-functions_framework_builder-gcp-integration_test
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.18.0"
+          sdk: "3.0.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -73,23 +73,23 @@ jobs:
         if: "always() && steps.integration_test_pub_upgrade.conclusion == 'success'"
         working-directory: integration_test
   job_002:
-    name: "unit_test; linux; Dart 2.18.0; PKG: gcp; `./tool/docker_test_script.sh`"
+    name: "unit_test; linux; Dart 3.0.0; PKG: gcp; `./tool/docker_test_script.sh`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:gcp;commands:command"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0;packages:gcp;commands:command"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:gcp
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0;packages:gcp
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.0.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.18.0"
+          sdk: "3.0.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -208,23 +208,23 @@ jobs:
         if: "always() && steps.integration_test_pub_upgrade.conclusion == 'success'"
         working-directory: integration_test
   job_005:
-    name: "unit_test; macos; Dart 2.18.0; PKG: gcp; `dart test`"
+    name: "unit_test; macos; Dart 3.0.0; PKG: gcp; `dart test`"
     runs-on: macos-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:macos-latest;pub-cache-hosted;sdk:2.18.0;packages:gcp;commands:test_0"
+          key: "os:macos-latest;pub-cache-hosted;sdk:3.0.0;packages:gcp;commands:test_0"
           restore-keys: |
-            os:macos-latest;pub-cache-hosted;sdk:2.18.0;packages:gcp
-            os:macos-latest;pub-cache-hosted;sdk:2.18.0
+            os:macos-latest;pub-cache-hosted;sdk:3.0.0;packages:gcp
+            os:macos-latest;pub-cache-hosted;sdk:3.0.0
             os:macos-latest;pub-cache-hosted
             os:macos-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.18.0"
+          sdk: "3.0.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab

analysis_options.yaml

@@ -1,5 +1,5 @@
 # https://dart.dev/guides/language/analysis-options
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   language:
@@ -9,11 +9,8 @@ analyzer:
 
 linter:
   rules:
-  - always_declare_return_types
   - avoid_bool_literals_in_conditional_expressions
-  - avoid_catching_errors
   - avoid_classes_with_only_static_members
-  - avoid_dynamic_calls
   - avoid_private_typedef_functions
   - avoid_redundant_argument_values
   - avoid_returning_null
@@ -23,31 +20,17 @@ linter:
   - cancel_subscriptions
   - cascade_invocations
   - comment_references
-  - directives_ordering
   - join_return_with_assignment
-  - lines_longer_than_80_chars
   - literal_only_boolean_expressions
   - missing_whitespace_between_adjacent_strings
   - no_runtimeType_toString
-  - omit_local_variable_types
-  - only_throw_errors
   - package_api_docs
-  - prefer_asserts_in_initializer_lists
   - prefer_const_constructors
   - prefer_const_declarations
   - prefer_expression_function_bodies
   - prefer_final_locals
   - prefer_relative_imports
-  - prefer_single_quotes
   - require_trailing_commas
-  - sort_pub_dependencies
   - test_types_in_equals
-  - throw_in_finally
-  - type_annotate_public_apis
-  - unawaited_futures
-  - unnecessary_lambdas
-  - unnecessary_parenthesis
-  - unnecessary_statements
-  - use_is_even_rather_than_modulo
   - use_string_buffers
   - use_super_parameters

dartfn/CHANGELOG.md

@@ -1,7 +1,8 @@
 ## 0.4.6-dev
 
 - Ignore file cleanup.
-- Require Dart 2.18
+- Require Dart 3.0
+- Support `package:http` v1
 
 ## 0.4.5
 

dartfn/lib/functions_framework_tool.dart

@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-library functions_framework_tool;
-
 export 'src/generators.dart';
 export 'src/printer.dart';
 export 'src/version.dart';

dartfn/lib/src/generators/cloudevent.g.dart

@@ -3,6 +3,8 @@
 // license that can be found in the LICENSE file.
 
 /// Some utility methods for stagehand.
+library;
+
 import 'dart:convert' show base64, utf8;
 
 import 'stagehand.dart';

dartfn/lib/src/generators/helloworld.g.dart

@@ -6,15 +6,15 @@ version: 0.4.6-dev
 homepage: https://github.com/GoogleCloudPlatform/functions-framework-dart
 
 environment:
-  sdk: '>=2.18.0 <3.0.0'
+  sdk: ^3.0.0
 
 executables:
   dartfn:
 
 dependencies:
   args: ^2.1.1
   collection: ^1.15.0
-  http: ^0.13.3
+  http: '>=0.13.3 <2.0.0'
   io: ^1.0.0
   path: ^1.7.0
   usage: ^4.0.2
@@ -25,9 +25,9 @@ dev_dependencies:
   build_runner: ^2.0.4
   build_verify: ^3.0.0
   build_version: ^2.1.1
+  dart_flutter_team_lints: ^1.0.0
   glob: ^2.0.0
   grinder: ^0.9.0
-  lints: ^2.0.0
   source_gen: ^1.0.0
   test: ^1.15.7
   yaml: ^3.1.0