Skip to content

Commit e80b2da

Browse files
authored
chore: Drop notify on failure, update deps (#486)
1 parent 818477f commit e80b2da

File tree

6 files changed

+16
-74
lines changed

6 files changed

+16
-74
lines changed

.github/workflows/lint.yml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -473,21 +473,3 @@ jobs:
473473
run: flutter analyze
474474
if: "always() && steps.examples_fullstack_frontend_pub_upgrade.conclusion == 'success'"
475475
working-directory: examples/fullstack/frontend
476-
job_007:
477-
name: Notify failure
478-
runs-on: ubuntu-latest
479-
if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()"
480-
steps:
481-
- run: |
482-
curl -H "Content-Type: application/json" -X POST -d \
483-
"{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
484-
"${CHAT_WEBHOOK_URL}"
485-
env:
486-
CHAT_WEBHOOK_URL: "${{ secrets.CHAT_WEBHOOK_URL }}"
487-
needs:
488-
- job_001
489-
- job_002
490-
- job_003
491-
- job_004
492-
- job_005
493-
- job_006

.github/workflows/unit.yml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -359,22 +359,3 @@ jobs:
359359
run: dart test
360360
if: "always() && steps.google_cloud_pub_upgrade.conclusion == 'success'"
361361
working-directory: google_cloud
362-
job_008:
363-
name: Notify failure
364-
runs-on: ubuntu-latest
365-
if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()"
366-
steps:
367-
- run: |
368-
curl -H "Content-Type: application/json" -X POST -d \
369-
"{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
370-
"${CHAT_WEBHOOK_URL}"
371-
env:
372-
CHAT_WEBHOOK_URL: "${{ secrets.CHAT_WEBHOOK_URL }}"
373-
needs:
374-
- job_001
375-
- job_002
376-
- job_003
377-
- job_004
378-
- job_005
379-
- job_006
380-
- job_007

functions_framework/lib/src/cloud_event.g.dart

Lines changed: 13 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

functions_framework/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ dev_dependencies:
2424
build_runner: ^2.2.1
2525
build_verify: ^3.0.0
2626
dart_flutter_team_lints: ^3.0.0
27-
json_serializable: ^6.6.0
27+
json_serializable: ^6.9.0
2828
test: ^1.21.6

integration_test/test/cli_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ void main() {
157157
await expectLater(
158158
proc.stderr,
159159
emitsInOrder([
160-
'Could not find an option named "bob".',
160+
'Could not find an option named "--bob".',
161161
...LineSplitter.split(_usage),
162162
]),
163163
);
@@ -193,7 +193,7 @@ void main() {
193193
await expectLater(
194194
proc.stderr,
195195
emitsInOrder([
196-
'"foo" is not an allowed value for option "signature-type".',
196+
'"foo" is not an allowed value for option "--signature-type".',
197197
...LineSplitter.split(_usage),
198198
]),
199199
);

mono_repo.yaml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,3 @@ github:
2525
name: Dart Unit CI
2626
stages:
2727
- unit_test
28-
29-
on_completion:
30-
- name: "Notify failure"
31-
runs-on: ubuntu-latest
32-
# Run only if other jobs have failed and this is a push or scheduled build.
33-
if: (github.event_name == 'push' || github.event_name == 'schedule') && failure()
34-
steps:
35-
- run: >
36-
curl -H "Content-Type: application/json" -X POST -d \
37-
"{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
38-
"${CHAT_WEBHOOK_URL}"
39-
env:
40-
CHAT_WEBHOOK_URL: ${{ secrets.CHAT_WEBHOOK_URL }}

0 commit comments

Comments
 (0)