Import of Cloud Functions JVM from Git-on-Borg.

  - 8a7701f8965dda3907dff901ad44584f1def4fde Update converter_test to use the new API. by Éamonn McManus <[email protected]>
  - 8033fd268a1c772ff99660de6a44a8af0f3c335e Add a comment to HttpResponseImpl.getWriter(). by Éamonn McManus <[email protected]>

PiperOrigin-RevId: 288965493

Author: eamonnmcmanus

invoker-core/core/src/main/java/com/google/cloud/functions/invoker/http/HttpResponseImpl.java

@@ -73,6 +73,10 @@ public synchronized BufferedWriter getWriter() throws IOException {
       // PrintWriter.out field via reflection, but that sort of access to non-public fields of
       // platform classes is now frowned on and may draw warnings or even fail in subsequent
       // versions.
+      // We could instead wrap the OutputStream, but that would require us to deduce the appropriate
+      // Charset, using logic like this:
+      // https://github.com/eclipse/jetty.project/blob/923ec38adf/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java#L731
+      // We may end up doing that if performance is an issue.
       writer = new BufferedWriter(response.getWriter());
     }
     return writer;