Skip to content

Commit d8417f3

Browse files
committed
Import of Cloud Functions JVM from Git-on-Borg.
- f1db675d9af38369700dc3434ef500749c6fe6aa Build with JDK11 not JDK8. by Éamonn McManus <[email protected]> - 4588713b3c7c168da51eb88dc0c1dc659cc55216 Change how exceptions are logged. by Éamonn McManus <[email protected]> PiperOrigin-RevId: 286397821
1 parent ee214a4 commit d8417f3

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

invoker-core/src/main/java/com/google/cloud/functions/invoker/NewHttpFunctionExecutor.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,12 @@ public void service(HttpServletRequest req, HttpServletResponse res) {
7070
try {
7171
function.service(reqImpl, respImpl);
7272
} catch (Throwable t) {
73+
// TODO(b/146510646): this should be logged properly as an exception, but that currently
74+
// causes integration tests to fail.
75+
// logger.log(Level.WARNING, "Failed to execute " + function.getClass().getName(), t);
76+
logger.log(Level.WARNING, "Failed to execute {0}", function.getClass().getName());
77+
t.printStackTrace();
7378
res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
74-
logger.log(Level.WARNING, "Failed to execute " + function.getClass().getName(), t);
7579
} finally {
7680
try {
7781
respImpl.getWriter().flush();

0 commit comments

Comments
 (0)