Skip to content

Commit 7134c91

Browse files
committed
fix: disable validateMapping for CloudEvent tests in ASGI mode
ASGI mode does not support automatic conversion from legacy events to CloudEvents, so validateMapping must be false for CloudEvent conformance tests.
1 parent ca13753 commit 7134c91

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/conformance-async.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
with:
6060
functionType: 'cloudevent'
6161
useBuildpacks: false
62-
validateMapping: true
62+
validateMapping: false
6363
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_cloud_event --signature-type cloudevent --gateway asgi'"
6464

6565
- name: Run HTTP conformance tests declarative
@@ -75,7 +75,7 @@ jobs:
7575
with:
7676
functionType: 'cloudevent'
7777
useBuildpacks: false
78-
validateMapping: true
78+
validateMapping: false
7979
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_cloud_event_declarative --gateway asgi'"
8080

8181
- name: Run HTTP concurrency tests declarative
@@ -86,4 +86,6 @@ jobs:
8686
validateConcurrency: true
8787
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_http_declarative_concurrent --gateway asgi'"
8888

89-
# Note: Event (legacy) and Typed tests are not supported in ASGI mode
89+
# Note: Event (legacy) and Typed tests are not supported in ASGI mode
90+
# Note: validateMapping is set to false for CloudEvent tests because ASGI mode
91+
# does not support automatic conversion from legacy events to CloudEvents

0 commit comments

Comments
 (0)