Fix test harness to support py37.

Author: taeold

conftest.py

@@ -42,3 +42,47 @@ def isolate_logging():
         sys.stderr = sys.__stderr__
         logging.shutdown()
         reload(logging)
+
+
+def pytest_collection_modifyitems(config, items):
+    """Skip async-related tests on Python 3.7 since Starlette requires Python 3.8+"""
+    if sys.version_info >= (3, 8):
+        return
+
+    skip_async = pytest.mark.skip(
+        reason="Async features require Python 3.8+ (Starlette dependency)"
+    )
+
+    for item in items:
+        skip_test = False
+
+        if hasattr(item, "callspec") and hasattr(item.callspec, "params"):
+            for param_name, param_value in item.callspec.params.items():
+                # Check if test has fixtures with async parameters
+                if isinstance(param_value, str) and (
+                    "async" in param_value or param_value.startswith("async_")
+                ):
+                    skip_test = True
+                    break
+                # Check if test is parametrized with create_asgi_app
+                if (
+                    hasattr(param_value, "__name__")
+                    and param_value.__name__ == "create_asgi_app"
+                ):
+                    skip_test = True
+                    break
+
+        # Check test file and function names for async-related test files
+        test_file = str(item.fspath)
+        test_name = item.name
+
+        # Skip tests in async-specific test files
+        if "test_aio" in test_file:
+            skip_test = True
+
+        # Skip tests that explicitly test async functionality
+        if "async" in test_name.lower() or "asgi" in test_name.lower():
+            skip_test = True
+
+        if skip_test:
+            item.add_marker(skip_async)

pyproject.toml

@@ -3,15 +3,13 @@ name = "functions-framework"
 version = "3.8.3"
 description = "An open source FaaS (Function as a service) framework for writing portable Python functions -- brought to you by the Google Cloud Functions team."
 readme = "README.md"
-requires-python = ">=3.5, <4"
+requires-python = ">=3.7, <4"
 # Once we drop support for Python 3.7 and 3.8, this can become
 # license = "Apache-2.0"
-license = {text = "Apache-2.0"}
-authors = [
-  { name = "Google LLC", email = "[email protected]" }
-]
+license = { text = "Apache-2.0" }
+authors = [{ name = "Google LLC", email = "[email protected]" }]
 maintainers = [
-  { name = "Google LLC", email = "[email protected]" }
+  { name = "Google LLC", email = "[email protected]" },
 ]
 keywords = ["functions-framework"]
 classifiers = [
@@ -31,13 +29,14 @@ dependencies = [
   "gunicorn>=22.0.0; platform_system!='Windows'",
   "cloudevents>=1.2.0,<2.0.0",
   "Werkzeug>=0.14,<4.0.0",
+  "httpx>=0.24.1",
 ]
 
 [project.urls]
 Homepage = "https://github.com/googlecloudplatform/functions-framework-python"
 
 [project.optional-dependencies]
-async = ["starlette>=0.37.0,<1.0.0"]
+async = ["starlette>=0.37.0,<1.0.0; python_version>='3.8'"]
 
 [project.scripts]
 ff = "functions_framework._cli:_cli"
@@ -58,3 +57,15 @@ functions_framework = ["py.typed"]
 
 [tool.setuptools.package-dir]
 "" = "src"
+
+[dependency-groups]
+dev = [
+    "black>=23.3.0",
+    "isort>=5.11.5",
+    "mypy>=1.4.1",
+    "pretend>=1.0.9",
+    "pytest>=7.4.4",
+    "pytest-asyncio>=0.21.2",
+    "pytest-cov>=4.1.0",
+    "pytest-integration>=0.2.3",
+]

tests/test_cloud_event_functions.py

@@ -13,15 +13,24 @@
 # limitations under the License.
 import json
 import pathlib
+import sys
 
 import pytest
 
 from cloudevents import conversion as ce_conversion
 from cloudevents.http import CloudEvent
-from starlette.testclient import TestClient as StarletteTestClient
+
+if sys.version_info >= (3, 8):
+    from starlette.testclient import TestClient as StarletteTestClient
+else:
+    StarletteTestClient = None
 
 from functions_framework import create_app
-from functions_framework.aio import create_asgi_app
+
+if sys.version_info >= (3, 8):
+    from functions_framework.aio import create_asgi_app
+else:
+    create_asgi_app = None
 
 TEST_FUNCTIONS_DIR = pathlib.Path(__file__).resolve().parent / "test_functions"
 TEST_DATA_DIR = pathlib.Path(__file__).resolve().parent / "test_data"

tests/test_decorator_functions.py

@@ -12,15 +12,26 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 import pathlib
+import sys
 
 import pytest
 
 from cloudevents import conversion as ce_conversion
 from cloudevents.http import CloudEvent
-from starlette.testclient import TestClient as StarletteTestClient
+
+# Conditional import for Starlette
+if sys.version_info >= (3, 8):
+    from starlette.testclient import TestClient as StarletteTestClient
+else:
+    StarletteTestClient = None
 
 from functions_framework import create_app
-from functions_framework.aio import create_asgi_app
+
+# Conditional import for async functionality
+if sys.version_info >= (3, 8):
+    from functions_framework.aio import create_asgi_app
+else:
+    create_asgi_app = None
 
 TEST_FUNCTIONS_DIR = pathlib.Path(__file__).resolve().parent / "test_functions"
 

tests/test_functions.py

@@ -15,17 +15,27 @@
 import json
 import pathlib
 import re
+import sys
 import time
 
 import pretend
 import pytest
 
-from starlette.testclient import TestClient as StarletteTestClient
+# Conditional import for Starlette
+if sys.version_info >= (3, 8):
+    from starlette.testclient import TestClient as StarletteTestClient
+else:
+    StarletteTestClient = None
 
 import functions_framework
 
 from functions_framework import LazyWSGIApp, create_app, errorhandler, exceptions
-from functions_framework.aio import create_asgi_app
+
+# Conditional import for async functionality
+if sys.version_info >= (3, 8):
+    from functions_framework.aio import create_asgi_app
+else:
+    create_asgi_app = None
 
 TEST_FUNCTIONS_DIR = pathlib.Path.cwd() / "tests" / "test_functions"
 

tox.ini

@@ -30,7 +30,8 @@ deps =
     pytest-integration
     pretend
 extras =
-    async
+    # Only include async extra for Python 3.8+
+    py{38,39,310,311,312}: async
 setenv =
     PYTESTARGS = --cov=functions_framework --cov-branch --cov-report term-missing --cov-fail-under=100
     windows-latest: PYTESTARGS =
@@ -44,6 +45,7 @@ deps =
     isort
     mypy
     build
+extras = async
 commands =
     black --check src tests conftest.py --exclude tests/test_functions/background_load_error/main.py
     isort -c src tests conftest.py