Skip to content

Commit 4f44d1d

Browse files
committed
add ruby 3.4 to coverage, use 3.2 for windows unit tests
1 parent 6b94681 commit 4f44d1d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/conformance.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
19-
ruby: ['3.1', '3.2', '3.3']
19+
ruby: ['3.1', '3.2', '3.3', '3.4']
2020
steps:
2121
- name: Harden Runner
2222
uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
@@ -71,4 +71,4 @@ jobs:
7171
useBuildpacks: false
7272
validateConcurrency: true
7373
cmd: "'bundle exec functions-framework-ruby --source test/conformance/app.rb --target concurrent_http_func --signature-type http'"
74-
74+

.github/workflows/unit.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ jobs:
1515
if: ${{ github.repository == 'GoogleCloudPlatform/functions-framework-ruby' }}
1616
strategy:
1717
matrix:
18-
os: [ubuntu-latest, windows-latest]
19-
ruby: ['3.1', '3.2', '3.3']
18+
os: [ubuntu-latest]
19+
ruby: ['3.1', '3.2', '3.3', '3.4']
2020
flags: ["--only --test-unit"]
2121
include:
2222
- os: ubuntu-latest
@@ -29,7 +29,7 @@ jobs:
2929
ruby: "3.1"
3030
flags: "--only --test-unit"
3131
- os: windows-latest
32-
ruby: "3.1"
32+
ruby: "3.2" # 3.1 fails similar to https://github.com/rubygems/rubygems/issues/4338
3333
flags: "--only --test-unit"
3434
- os: ubuntu-latest
3535
ruby: "3.1"

0 commit comments

Comments
 (0)