From 2cc28a700f017a9f2068bd3ca0f68b7f53723c33 Mon Sep 17 00:00:00 2001 From: Chaitanya Kulkarni Date: Mon, 30 Mar 2026 16:36:04 -0700 Subject: [PATCH] The test now locks the backend metrics mutex before reading error and success counts to avoid data races in tests. PiperOrigin-RevId: 891976047 --- galog_syslog_linux_test.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/galog_syslog_linux_test.go b/galog_syslog_linux_test.go index ecb94a1..6965a93 100644 --- a/galog_syslog_linux_test.go +++ b/galog_syslog_linux_test.go @@ -77,12 +77,18 @@ func TestSyslog(t *testing.T) { time.Sleep(time.Millisecond) } - if be.metrics.errors != 0 { - t.Errorf("got errors %d, want 0. Errors: \n%s\n", be.metrics.errors, strings.Join(be.metrics.errorMsgs, "\n")) + be.metrics.mu.Lock() + errors := be.metrics.errors + errorMsgs := be.metrics.errorMsgs + successMetric := be.metrics.success + be.metrics.mu.Unlock() + + if errors != 0 { + t.Errorf("got errors %d, want 0. Errors: \n%s\n", errors, strings.Join(errorMsgs, "\n")) } if !success { - t.Errorf("got success %d, want %d", be.metrics.success, writtenEntries+1) + t.Errorf("got success %d, want %d", successMetric, writtenEntries+1) } }) }