Skip to content

Commit 6d5830c

Browse files
authored
Merge pull request #1226 from chrisThePattyEater/automated-cherry-pick-of-#1225-upstream-release-1.22
Automated cherry pick of #1225: Revert "Denoise force unpublish"
2 parents d6f0185 + 8dbfa47 commit 6d5830c

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

pkg/csi_driver/node.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -407,13 +407,7 @@ func (s *nodeServer) NodeUnpublishVolume(_ context.Context, req *csi.NodeUnpubli
407407
forceUnmounter, ok := s.mounter.(mount.MounterForceUnmounter)
408408
if ok {
409409
if err = forceUnmounter.UnmountWithForce(targetPath, UmountTimeout); err != nil {
410-
mounted, isMountedErr := s.isDirMounted(targetPath)
411-
if mounted || isMountedErr != nil {
412-
// If it's still mounted OR we couldn't check, return the original error
413-
return nil, status.Errorf(codes.Internal, "failed to force unmount target path %q: %v", targetPath, err)
414-
}
415-
// The mount is gone, so we treat the unmountErr as a false positive (warning only).
416-
klog.Warningf("failed to force unmount target path (%q) because mount is already gone. Proceeding.", targetPath)
410+
return nil, status.Errorf(codes.Internal, "failed to force unmount target path %q: %v", targetPath, err)
417411
}
418412
} else {
419413
klog.Warningf("failed to cast the mounter to a forceUnmounter, proceed with the default mounter Unmount")

0 commit comments

Comments
 (0)