Show warning when m2e _do not update remote-dependencies_ setting is on (#1044)

Author: briandealwis

plugins/com.google.cloud.tools.eclipse.appengine.newproject.maven/src/com/google/cloud/tools/eclipse/appengine/newproject/maven/CreateMavenBasedAppEngineStandardProject.java

@@ -20,6 +20,7 @@
 import com.google.cloud.tools.eclipse.appengine.libraries.model.Library;
 import com.google.cloud.tools.eclipse.util.MavenUtils;
 import java.lang.reflect.InvocationTargetException;
+import java.util.Collection;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Properties;
@@ -132,10 +133,10 @@ void setArchetype(Archetype archetype) {
     this.archetype = archetype;
   }
 
-  void setAppEngineLibraryIds(List<Library> libraries) {
+  void setAppEngineLibraryIds(Collection<Library> libraries) {
     appEngineLibraryIds = new HashSet<String>();
-    for (int i = 0; i < libraries.size(); i++) {
-      appEngineLibraryIds.add(libraries.get(i).getId());
+    for (Library library : libraries) {
+      appEngineLibraryIds.add(library.getId());
     }
   }
 

plugins/com.google.cloud.tools.eclipse.appengine.newproject.maven/src/com/google/cloud/tools/eclipse/appengine/newproject/maven/MavenAppEngineStandardWizardPage.java

@@ -25,19 +25,23 @@
 import com.google.cloud.tools.io.FilePermissions;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.CharMatcher;
-import java.text.MessageFormat;
-import java.util.List;
 import java.io.IOException;
 import java.nio.file.FileAlreadyExistsException;
 import java.nio.file.Paths;
+import java.text.MessageFormat;
+import java.util.Collection;
+import org.eclipse.aether.repository.RepositoryPolicy;
 import org.eclipse.core.resources.ResourcesPlugin;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.jface.dialogs.Dialog;
 import org.eclipse.jface.layout.GridDataFactory;
 import org.eclipse.jface.layout.GridLayoutFactory;
+import org.eclipse.jface.viewers.ISelectionChangedListener;
+import org.eclipse.jface.viewers.SelectionChangedEvent;
 import org.eclipse.jface.wizard.WizardPage;
+import org.eclipse.m2e.core.MavenPlugin;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.events.ModifyEvent;
 import org.eclipse.swt.events.ModifyListener;
@@ -111,6 +115,12 @@ public void createControl(Composite parent) {
     createMavenCoordinatesArea(container);
     createAppEngineProjectDetailsArea(container);
     appEngineLibrariesSelectorGroup = new AppEngineLibrariesSelectorGroup(container);
+    appEngineLibrariesSelectorGroup.addSelectionChangedListener(new ISelectionChangedListener() {
+      @Override
+      public void selectionChanged(SelectionChangedEvent event) {
+        validatePage();
+      }
+    });
 
     Dialog.applyDialogFont(container);
   }
@@ -268,10 +278,19 @@ private boolean validatePage() {
     if (!validateAppEngineProjectDetails()) {
       return false;
     }
+    checkMavenUpdateSettings();
 
     return true;
   }
 
+  private void checkMavenUpdateSettings() {
+    String globalUpdatePolicy = MavenPlugin.getMavenConfiguration().getGlobalUpdatePolicy();
+    if (!appEngineLibrariesSelectorGroup.getSelectedLibraries().isEmpty()
+        && RepositoryPolicy.UPDATE_POLICY_NEVER.equals(globalUpdatePolicy)) {
+      setMessage(Messages.getString("M2E_GLOBAL_UPDATES_PREVENT_CHECKS"), WARNING);
+    }
+  }
+
   @VisibleForTesting
   static boolean validateLocation(String location, WizardPage page) {
     if (location.isEmpty()) {
@@ -294,7 +313,7 @@ static boolean validateLocation(String location, WizardPage page) {
     }
   }
 
-  public List<Library> getSelectedLibraries() {
+  public Collection<Library> getSelectedLibraries() {
     return appEngineLibrariesSelectorGroup.getSelectedLibraries();
   }
 

plugins/com.google.cloud.tools.eclipse.appengine.newproject.maven/src/com/google/cloud/tools/eclipse/appengine/newproject/maven/messages.properties

@@ -28,3 +28,4 @@ MAVEN_PROJECT_COORDINATES=Maven project coordinates
 GROUP_ID=Group ID:
 ARTIFACT_ID=Artifact ID:
 ARTIFACT_VERSION=Version:
+M2E_GLOBAL_UPDATES_PREVENT_CHECKS=Maven settings prevent checking for later versions of selected libraries 

plugins/com.google.cloud.tools.eclipse.appengine.newproject.test/src/com/google/cloud/tools/eclipse/appengine/newproject/AppEngineStandardProjectConfigTest.java

@@ -23,7 +23,6 @@
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.util.Collections;
-
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IWorkspace;
 import org.eclipse.core.resources.ResourcesPlugin;
@@ -61,7 +60,7 @@ public void testEclipseProjectLocationUri() throws URISyntaxException {
 
   @Test
   public void testAppEngineLibraries() {
-    config.setAppEngineLibraries(Collections.singletonList(new Library("app-engine-library")));
+    config.setAppEngineLibraries(Collections.singleton(new Library("app-engine-library")));
     assertThat(config.getAppEngineLibraries().size(), is(1));
     assertThat(config.getAppEngineLibraries().iterator().next().getId(), is("app-engine-library"));
   }

plugins/com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject/AppEngineStandardProjectConfig.java

@@ -19,8 +19,9 @@
 import com.google.cloud.tools.eclipse.appengine.libraries.model.Library;
 import java.io.File;
 import java.net.URI;
+import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
-import java.util.LinkedList;
 import java.util.List;
 import org.eclipse.core.resources.IProject;
 
@@ -34,7 +35,6 @@ class AppEngineStandardProjectConfig {
   private IProject project;
   private List<Library> appEngineLibraries = Collections.emptyList();
 
-
   public File getCloudSdkLocation() {
     return cloudSdkLocation;
   }
@@ -74,8 +74,8 @@ public List<Library> getAppEngineLibraries() {
     return appEngineLibraries;
   }
 
-  public void setAppEngineLibraries(List<Library> libraries) {
-    this.appEngineLibraries = new LinkedList<>(libraries);
+  public void setAppEngineLibraries(Collection<Library> libraries) {
+    this.appEngineLibraries = new ArrayList<>(libraries);
   }
 
 }

plugins/com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject/AppEngineStandardWizardPage.java

@@ -16,9 +16,13 @@
 
 package com.google.cloud.tools.eclipse.appengine.newproject;
 
+import com.google.cloud.tools.eclipse.appengine.libraries.model.Library;
+import com.google.cloud.tools.eclipse.appengine.ui.AppEngineImages;
+import com.google.cloud.tools.eclipse.appengine.ui.AppEngineLibrariesSelectorGroup;
+import com.google.cloud.tools.eclipse.usagetracker.AnalyticsEvents;
+import com.google.cloud.tools.eclipse.usagetracker.AnalyticsPingManager;
 import java.io.File;
-import java.util.List;
-
+import java.util.Collection;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.jface.dialogs.Dialog;
 import org.eclipse.swt.SWT;
@@ -29,11 +33,6 @@
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
 import org.eclipse.ui.dialogs.WizardNewProjectCreationPage;
-import com.google.cloud.tools.eclipse.appengine.libraries.model.Library;
-import com.google.cloud.tools.eclipse.appengine.ui.AppEngineLibrariesSelectorGroup;
-import com.google.cloud.tools.eclipse.appengine.ui.AppEngineImages;
-import com.google.cloud.tools.eclipse.usagetracker.AnalyticsEvents;
-import com.google.cloud.tools.eclipse.usagetracker.AnalyticsPingManager;
 
 /**
  * UI to collect all information necessary to create a new App Engine Standard Java Eclipse project.
@@ -119,7 +118,7 @@ public String getPackageName() {
     return this.javaPackageField.getText();
   }
 
-  public List<Library> getSelectedLibraries() {
+  public Collection<Library> getSelectedLibraries() {
     return appEngineLibrariesSelectorGroup.getSelectedLibraries();
   }
 

plugins/com.google.cloud.tools.eclipse.appengine.ui.test/src/com/google/cloud/tools/eclipse/appengine/ui/AppEngineLibrariesSelectorGroupTest.java

@@ -24,6 +24,7 @@
 
 import com.google.cloud.tools.eclipse.appengine.libraries.model.Library;
 import com.google.cloud.tools.eclipse.test.util.ui.ShellTestResource;
+import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
@@ -251,7 +252,7 @@ private void syncExec(Runnable runnable) {
   }
 
   private List<Library> getSelectedLibrariesSorted() {
-    List<Library> selectedLibraries = librariesSelector.getSelectedLibraries();
+    List<Library> selectedLibraries = new ArrayList<>(librariesSelector.getSelectedLibraries());
     Collections.sort(selectedLibraries, new Comparator<Library>() {
 
       @Override

plugins/com.google.cloud.tools.eclipse.appengine.ui/META-INF/MANIFEST.MF

@@ -8,6 +8,7 @@ Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-1.7
 Export-Package: com.google.cloud.tools.eclipse.appengine.ui
 Import-Package: com.google.cloud.tools.eclipse.appengine.libraries.model,
+ org.eclipse.core.runtime;version="3.5.0",
  com.google.common.annotations;version="20.0.0",
  com.google.common.base;version="20.0.0",
  org.eclipse.core.databinding,
@@ -20,6 +21,7 @@ Import-Package: com.google.cloud.tools.eclipse.appengine.libraries.model,
  org.eclipse.jface.dialogs,
  org.eclipse.jface.layout,
  org.eclipse.jface.resource,
+ org.eclipse.jface.viewers,
  org.eclipse.jface.wizard,
  org.eclipse.osgi.util;version="1.1.0",
  org.eclipse.swt,