Rename appengine.blacklist.marker to appengine.problem.marker (#3634)

Author: briandealwis

plugins/com.google.cloud.tools.eclipse.appengine.validation.test/src/com/google/cloud/tools/eclipse/appengine/validation/ApplicationSourceQuickFixTest.java

@@ -46,7 +46,7 @@
 public class ApplicationSourceQuickFixTest {
 
   private static final String MARKER =
-      "com.google.cloud.tools.eclipse.appengine.validation.appEngineBlacklistMarker";
+      "com.google.cloud.tools.eclipse.appengine.validation.appEngineProblemMarker";
 
   private static final String APPLICATION_XML =
       "<appengine-web-app xmlns='http://appengine.google.com/ns/1.0'>"

plugins/com.google.cloud.tools.eclipse.appengine.validation.test/src/com/google/cloud/tools/eclipse/appengine/validation/XmlValidatorTest.java

@@ -48,7 +48,7 @@ public class XmlValidatorTest {
       + "<runtime>java8</runtime></application>";
   private static final String BAD_XML = "<";
   private static final String APPLICATION_MARKER =
-      "com.google.cloud.tools.eclipse.appengine.validation.appEngineBlacklistMarker";
+      "com.google.cloud.tools.eclipse.appengine.validation.appEngineProblemMarker";
 
   @Rule public TestProjectCreator appEngineStandardProjectCreator =
       new TestProjectCreator().withFacets(JavaFacet.VERSION_1_7, WebFacetUtils.WEB_25,

plugins/com.google.cloud.tools.eclipse.appengine.validation/plugin.properties

@@ -4,7 +4,7 @@ pluginName = Cloud Tools for Eclipse App Engine Checks
 extension.name=App Engine Source Code Validation
 appengine.web=App Engine Web XML Validator
 pom.validator=Pom Validator
-appengine.blacklist.marker=App Engine Configuration Problem
+appengine.problem.marker=App Engine Configuration Problem
 web.xml=Web XML Validator
 servlet.marker=Servlet Marker
 maven.plugin.marker=Obsolete Maven App Engine Plugin

plugins/com.google.cloud.tools.eclipse.appengine.validation/plugin.xml

@@ -8,8 +8,8 @@
       id="appEngineWebXmlValidator">
     <!-- TODO should this specify more than one marker type? -->
     <validator
-    	class="com.google.cloud.tools.eclipse.appengine.validation.XmlValidator:com.google.cloud.tools.eclipse.appengine.validation.AppEngineWebXmlValidator"
-      	markerId="com.google.cloud.tools.eclipse.appengine.validation.appEngineBlacklistMarker">
+        class="com.google.cloud.tools.eclipse.appengine.validation.XmlValidator:com.google.cloud.tools.eclipse.appengine.validation.AppEngineWebXmlValidator"
+        markerId="com.google.cloud.tools.eclipse.appengine.validation.appEngineProblemMarker">
       <include>
         <rules>
           <file type="file" name="appengine-web.xml"/>
@@ -85,8 +85,8 @@
 
 
   <extension
-      id="appEngineBlacklistMarker"
-      name="%appengine.blacklist.marker"
+      id="appEngineProblemMarker"
+      name="%appengine.problem.marker"
       point="org.eclipse.core.resources.markers">
     <super type="org.eclipse.jdt.core.problem" />
     <super type="org.eclipse.core.resources.problemmarker" />
@@ -98,15 +98,15 @@
       id="applicationMarker"
       name="%remove.application.element"
       point="org.eclipse.core.resources.markers">
-    <super type="com.google.cloud.tools.eclipse.appengine.validation.appEngineBlacklistMarker" />
+    <super type="com.google.cloud.tools.eclipse.appengine.validation.appEngineProblemMarker" />
     <persistent value="true" />
   </extension>
 
   <extension
       id="versionMarker"
       name="%remove.version.element"
       point="org.eclipse.core.resources.markers">
-    <super type="com.google.cloud.tools.eclipse.appengine.validation.appEngineBlacklistMarker" />
+    <super type="com.google.cloud.tools.eclipse.appengine.validation.appEngineProblemMarker" />
     <persistent value="true" />
   </extension>
 
@@ -248,9 +248,9 @@
    <extension
          point="org.eclipse.ui.ide.markerSupport">
       <markerTypeCategory
-            name="%appengine.blacklist.marker">
+            name="%appengine.problem.marker">
          <markerTypeReference
-               id="com.google.cloud.tools.eclipse.appengine.validation.appEngineBlacklistMarker"/>
+               id="com.google.cloud.tools.eclipse.appengine.validation.appEngineProblemMarker"/>
          <markerTypeReference
                id="com.google.cloud.tools.eclipse.appengine.validation.applicationMarker"/>
          <markerTypeReference