Make 2018-09 the default target (#3592)

* make 2018-09 the default target
* update README

Author: elharo

.travis.yml

@@ -12,22 +12,21 @@ install:
   - mvn -B -N io.takari:maven:wrapper -Dmaven=3.5.4
   # download and install Cloud SDK (may be cached)
   - build/install-cloudsdk.sh 241.0.0 $HOME
-# ECLIPSE_TARGET is the targeted platform: photon is the default target
+# ECLIPSE_TARGET is the targeted platform: 2018-09 is the default target
 # We run jacoco on photon
 matrix:
   include:
     - name: "Eclipse Photon (4.8) on Java 8"
       jdk: oraclejdk8
       dist: trusty
-      env: MAVEN_FLAGS='-Pjacoco'
+      env: ECLIPSE_TARGET=photon MAVEN_FLAGS='-Pjacoco'
     - name: "Eclipse 2018-09 (4.9) on Java 8"
       jdk: oraclejdk8
       dist: trusty
-      env: ECLIPSE_TARGET=2018-09
     - name: "Eclipse 2018-09 (4.9) on Java 11"
       jdk: openjdk11
       dist: trusty
-      env: ECLIPSE_TARGET=2018-09 MAVEN_FLAGS='--toolchains=.travisci/toolchains.xml'
+      env: MAVEN_FLAGS='--toolchains=.travisci/toolchains.xml'
     - name: "Eclipse 2018-12 (4.10) on Java 11"
       dist: trusty
       jdk: openjdk11

README.md

@@ -76,11 +76,11 @@ The tests need to find the Google Cloud SDK.  You can either:
 
 ### Changing the Eclipse Platform compilation and testing target
 
-By default, the build is targeted against Eclipse Photon / 4.8.
+By default, the build is targeted against Eclipse `2018-09` (4.9).
 You can explicitly set the `eclipse.target` property to
-`2018-09` (4.9), or `2018-12` (4.10).
+`photon` (4.8), or `2018-12` (4.10).
 ```
-$ mvn -Declipse.target=2018-09 package
+$ mvn -Declipse.target=2018-12 package
 ```
 
 ### Adding a new bundle/fragment

pom.xml

@@ -43,7 +43,7 @@
     <tycho-extras.version>1.3.0</tycho-extras.version>
     <product.version.qualifier.suffix/>  <!-- 0-length string by default -->
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <eclipse.target>photon</eclipse.target> <!-- the default build -->
+    <eclipse.target>2018-09</eclipse.target> <!-- the default build -->
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
 
@@ -417,10 +417,8 @@
     <profile>
       <id>build-eclipse-photon</id>
       <activation>
-        <!-- Default target if no eclipse.target specified. -->
         <property>
-          <name>!eclipse.target</name>
-          <!-- when no longer the default: <name>eclipse.target</name> <value>photon</value> -->
+          <name>eclipse.target</name> <value>photon</value>
         </property>
       </activation>
       <properties>
@@ -451,10 +449,12 @@
     </profile>
 
     <profile>
+      <!-- Default target if no eclipse.target specified. -->
       <id>build-eclipse-2018-09</id>
       <activation>
         <property>
-          <name>eclipse.target</name> <value>2018-09</value>
+          <name>!eclipse.target</name>
+          <!-- when no longer the default: <name>eclipse.target</name> <value>2018-09</value> -->
         </property>
       </activation>
       <properties>