fix: correct ptos disable configuration in tests (#3696)

some poms had their <disablePrivacyTos/> tag in the wrong plugin
configuration.

Author: diegomarquezp

plugins/com.google.cloud.tools.eclipse.appengine.deploy.test/pom.xml

@@ -16,14 +16,16 @@
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>tycho-surefire-plugin</artifactId>
+        <configuration>
+          <systemProperties>
+            <disablePrivacyTos>true</disablePrivacyTos>
+          </systemProperties>
+        </configuration>
       </plugin>
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>target-platform-configuration</artifactId>
         <configuration>
-          <systemProperties>
-            <disablePrivacyTos>true</disablePrivacyTos>
-          </systemProperties>
           <dependency-resolution>
             <extraRequirements>
               <requirement>

plugins/com.google.cloud.tools.eclipse.appengine.facets.test/pom.xml

@@ -16,14 +16,16 @@
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>tycho-surefire-plugin</artifactId>
+        <configuration>
+          <systemProperties>
+            <disablePrivacyTos>true</disablePrivacyTos>
+          </systemProperties>
+        </configuration>
       </plugin>
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>target-platform-configuration</artifactId>
         <configuration>
-          <systemProperties>
-            <disablePrivacyTos>true</disablePrivacyTos>
-          </systemProperties>
           <dependency-resolution>
             <extraRequirements>
               <requirement>

plugins/com.google.cloud.tools.eclipse.appengine.libraries.ui.test/pom.xml

@@ -16,14 +16,16 @@
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>tycho-surefire-plugin</artifactId>
+        <configuration>
+            <systemProperties>
+              <disablePrivacyTos>true</disablePrivacyTos>
+            </systemProperties>
+        </configuration>
       </plugin>
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>target-platform-configuration</artifactId>
         <configuration>
-          <systemProperties>
-            <disablePrivacyTos>true</disablePrivacyTos>
-          </systemProperties>
           <dependency-resolution>
             <extraRequirements>
               <requirement>

plugins/com.google.cloud.tools.eclipse.googleapis.test/pom.xml

@@ -16,6 +16,11 @@
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>tycho-surefire-plugin</artifactId>
+        <configuration>
+            <systemProperties>
+              <disablePrivacyTos>true</disablePrivacyTos>
+            </systemProperties>
+        </configuration>
       </plugin>
     </plugins>
   </build>

plugins/com.google.cloud.tools.eclipse.login.test/pom.xml

@@ -16,6 +16,11 @@
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>tycho-surefire-plugin</artifactId>
+        <configuration>
+            <systemProperties>
+              <disablePrivacyTos>true</disablePrivacyTos>
+            </systemProperties>
+        </configuration>
       </plugin>
     </plugins>
   </build>

plugins/com.google.cloud.tools.eclipse.ui.test/pom.xml

@@ -17,10 +17,10 @@
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>tycho-surefire-plugin</artifactId>
         <configuration>
-        <systemProperties>
+          <systemProperties>
             <disablePrivacyTos>true</disablePrivacyTos>
-        </systemProperties>
-    </configuration>
+          </systemProperties>
+        </configuration>
       </plugin>
     </plugins>
   </build>