Skip to content

Commit bd52287

Browse files
authored
use libraries-bom in pom.xml (#3583)
1 parent 431c2fc commit bd52287

File tree

5 files changed

+10
-10
lines changed
  • plugins
    • com.google.cloud.tools.eclipse.appengine.libraries.test/src/com/google/cloud/tools/eclipse/appengine/libraries
    • com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries
    • com.google.cloud.tools.eclipse.appengine.newproject.test/src/com/google/cloud/tools/eclipse/appengine/newproject
    • com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject
    • com.google.cloud.tools.eclipse.util/templates/appengine

5 files changed

+10
-10
lines changed

plugins/com.google.cloud.tools.eclipse.appengine.libraries.test/src/com/google/cloud/tools/eclipse/appengine/libraries/Bug3380Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public void testBug3380() throws CoreException, XPathExpressionException {
105105
Assert.assertTrue(pom.dependencyManaged("com.google.cloud", "google-cloud-automl"));
106106

107107
Element bomElement = (Element) xpath.evaluate(
108-
"//m:dependencyManagement/m:dependencies/m:dependency[m:groupId='com.google.cloud'][m:artifactId='google-cloud-bom']",
108+
"//m:dependencyManagement/m:dependencies/m:dependency[m:groupId='com.google.cloud'][m:artifactId='libraries-bom']",
109109
pom.document.getDocumentElement(), XPathConstants.NODE);
110110
Assert.assertNotNull(bomElement); // Make sure BOM element added
111111

plugins/com.google.cloud.tools.eclipse.appengine.libraries/src/com/google/cloud/tools/eclipse/appengine/libraries/Pom.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ private void handleDependencyManaged(LibraryFile artifact, Element dependency) {
287287
private void createBOMIfNeeded(XPath xpath) throws CoreException {
288288
try {
289289
Element bomElement = (Element) xpath.evaluate(
290-
"//m:dependencyManagement/m:dependencies/m:dependency[m:groupId='com.google.cloud'][m:artifactId='google-cloud-bom']",
290+
"//m:dependencyManagement/m:dependencies/m:dependency[m:groupId='com.google.cloud'][m:artifactId='libraries-bom']",
291291
document.getDocumentElement(), XPathConstants.NODE);
292292
if (bomElement == null) {
293293
Element dependencies = null;
@@ -312,12 +312,12 @@ private void createBOMIfNeeded(XPath xpath) throws CoreException {
312312
Element dependency =
313313
document.createElementNS("http://maven.apache.org/POM/4.0.0", "dependency");
314314
dependency.appendChild(createChild("groupId", "com.google.cloud"));
315-
dependency.appendChild(createChild("artifactId", "google-cloud-bom"));
315+
dependency.appendChild(createChild("artifactId", "libraries-bom"));
316316
dependency.appendChild(createChild("type", "pom"));
317317
dependency.appendChild(createChild("scope", "import"));
318-
String version = getBestVersion("com.google.cloud", "google-cloud-bom");
318+
String version = getBestVersion("com.google.cloud", "libraries-bom");
319319
dependency.appendChild(createChild("version", version));
320-
Bom bom = Bom.loadBom("com.google.cloud", "google-cloud-bom", version, null);
320+
Bom bom = Bom.loadBom("com.google.cloud", "libraries-bom", version, null);
321321
if (bom != null) {
322322
boms.add(bom);
323323
}

plugins/com.google.cloud.tools.eclipse.appengine.newproject.test/src/com/google/cloud/tools/eclipse/appengine/newproject/CodeTemplatesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ private Element validatePom() throws ParserConfigurationException, SAXException,
432432
"string(./m:dependencyManagement/m:dependencies/m:dependency/m:artifactId)",
433433
root,
434434
XPathConstants.STRING);
435-
Assert.assertEquals("google-cloud-bom", bomArtifactId);
435+
Assert.assertEquals("libraries-bom", bomArtifactId);
436436

437437
DefaultArtifactVersion bomVersion = new DefaultArtifactVersion((String) xpath.evaluate(
438438
"string(./m:dependencyManagement/m:dependencies/m:dependency/m:version)",

plugins/com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject/CodeTemplates.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,14 +238,14 @@ private static void createPomXml(IProject project, AppEngineProjectConfig config
238238

239239
String bomVersion = getCurrentVersion(
240240
"com.google.cloud", //$NON-NLS-1$
241-
"google-cloud-bom", //$NON-NLS-1$
242-
"0.91.0-alpha"); //$NON-NLS-1$
241+
"libraries-bom", //$NON-NLS-1$
242+
"3.1.0"); //$NON-NLS-1$
243243
properties.put("googleCloudJavaBomVersion", bomVersion); //$NON-NLS-1$
244244

245245
String mavenPluginVersion = getCurrentVersion(
246246
"com.google.cloud.tools", //$NON-NLS-1$
247247
"appengine-maven-plugin", //$NON-NLS-1$
248-
"2.0.0"); //$NON-NLS-1$
248+
"2.2.0"); //$NON-NLS-1$
249249
properties.put("mavenPluginVersion", mavenPluginVersion); //$NON-NLS-1$
250250

251251
if (isServlet25Selected(config)) {

plugins/com.google.cloud.tools.eclipse.util/templates/appengine/pom.xml.ftl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<dependencies>
2424
<dependency>
2525
<groupId>com.google.cloud</groupId>
26-
<artifactId>google-cloud-bom</artifactId>
26+
<artifactId>libraries-bom</artifactId>
2727
<version>${googleCloudJavaBomVersion}</version>
2828
<type>pom</type>
2929
<scope>import</scope>

0 commit comments

Comments
 (0)