remove photon support (#3614)

* remove photon support

* turn on photon ignored test

Author: elharo

.travis.yml

@@ -20,9 +20,6 @@ install:
 # We run jacoco on photon
 matrix:
   include:
-    - name: "Eclipse Photon (4.8) on Java 8"
-      jdk: openjdk8
-      env: ECLIPSE_TARGET=photon MAVEN_FLAGS='-Pjacoco'
     - name: "Eclipse 2018-09 (4.9) on Java 8"
       jdk: openjdk8
     - name: "Eclipse 2018-09 (4.9) on Java 11"

README.md

@@ -26,7 +26,7 @@ Maven for building Eclipse bundles and features.
 
 4. The [Eclipse IDE](https://www.eclipse.org/downloads/eclipse-packages/).
    It's easiest to use the _Eclipse IDE for Java EE Developers_ package. You must use
-   Eclipse 4.7 (Oxygen) or later.  We use _target platforms_ to support building
+   Eclipse 4.9 or later.  We use _target platforms_ to support building
    for earlier versions of Eclipse.  You also need the following:
 
    1. The [M2Eclipse plugin](http://www.eclipse.org/m2e/) (also called m2e) is
@@ -77,8 +77,7 @@ The tests need to find the Google Cloud SDK.  You can either:
 ### Changing the Eclipse Platform compilation and testing target
 
 By default, the build is targeted against Eclipse `2018-09` (4.9).
-You can explicitly set the `eclipse.target` property to
-`photon` (4.8), or `2018-12` (4.10).
+You can explicitly set the `eclipse.target` property to `2018-12` (4.10).
 ```
 $ mvn -Declipse.target=2018-12 package
 ```
@@ -265,7 +264,6 @@ features being built against. We currently maintain three target platforms,
 targeting the latest version of the current, previous, and next releases.
 This is currently:
 
-  - Eclipse Photon (4.8): [`eclipse/photon/gcp-eclipse-photon.target`](eclipse/photon/gcp-eclipse-photon.target)
   - Eclipse 2018-09 (4.9): [`eclipse/eclipse-2018-09/gcp-eclipse-2018-09.target`](eclipse/eclipse-2018-09/gcp-eclipse-2018-09.target)
   - Eclipse 2018-12 (4.10): [`eclipse/eclipse-2018-12/gcp-eclipse-2018-12.target`](eclipse/eclipse-2018-12/gcp-eclipse-2018-12.target)
 

eclipse/photon/.settings/org.eclipse.core.resources.prefs

@@ -14,7 +14,6 @@
   <packaging>pom</packaging>
 
   <modules>
-    <module>photon</module>
     <module>eclipse-2018-09</module>
     <module>eclipse-2018-12</module>
     <module>eclipse-2019-09</module>

eclipse/photon/.settings/org.eclipse.m2e.core.prefs

@@ -35,7 +35,6 @@
 import org.eclipse.wst.common.project.facet.core.IFacetedProject;
 import org.eclipse.wst.common.project.facet.core.IProjectFacetVersion;
 import org.eclipse.wst.common.project.facet.core.ProjectFacetsManager;
-import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
@@ -52,8 +51,6 @@ public class ImportMavenAppEngineStandardProjectTest extends BaseProjectTest {
   @Rule
   public TemporaryFolder tempFolder = new TemporaryFolder();
 
-  // flaking on Photon: https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/3256
-  @Ignore
   @Test
   public void runImport() throws IOException, CoreException {
     assertFalse(projectExists("springboot-appengine-standard"));

eclipse/photon/gcp-eclipse-photon.target

@@ -415,40 +415,6 @@
       </properties>
     </profile>
 
-    <profile>
-      <id>build-eclipse-photon</id>
-      <activation>
-        <property>
-          <name>eclipse.target</name> <value>photon</value>
-        </property>
-      </activation>
-      <properties>
-         <jettyMinVersion>9.4</jettyMinVersion>
-         <jettyMaxVersion>9.5</jettyMaxVersion>
-      </properties>
-      <!-- build against a known target platform -->
-      <modules>
-        <module>eclipse/photon</module>
-      </modules>
-      <build>
-        <plugins>
-          <plugin>
-            <groupId>org.eclipse.tycho</groupId>
-            <artifactId>target-platform-configuration</artifactId>
-            <configuration>
-            <target>
-              <artifact>
-                <groupId>com.google.cloud.tools.eclipse</groupId>
-                <artifactId>gcp-eclipse-photon</artifactId>
-                <version>4.8.0-SNAPSHOT</version>
-              </artifact>
-            </target>
-           </configuration>
-          </plugin>
-        </plugins>
-      </build>
-    </profile>
-
     <profile>
       <!-- Default target if no eclipse.target specified. -->
       <id>build-eclipse-2018-09</id>