Fixes missing gcloud checks. (#819)

* Add proper check for gcloud.

* Check for gcloud.

Author: ivannaranjo

GoogleCloudExtension/GoogleCloudExtension.Deployment/WindowsVmDeployment.cs

@@ -138,7 +138,17 @@ private static async Task<bool> CreateAppBundleAsync(
 
             outputAction($"msbuild.exe {arguments}");
             bool result = await ProcessUtils.RunCommandAsync(toolsPathProvider.GetMsbuildPath(), arguments, (o, e) => outputAction(e.Line));
-            await GCloudWrapper.GenerateSourceContext(project.DirectoryPath, stageDirectory);
+
+            // We perform this check here because it is not required to have gcloud installed in order to deploy
+            // ASP.NET 4.x apps to GCE VMs. Therefore nothing would have checked for the presence of gcloud before
+            // getting here.
+            var gcloudValidation = await GCloudWrapper.ValidateGCloudAsync();
+            Debug.WriteLineIf(!gcloudValidation.IsValid, "Skipping creating context, gcloud is not installed.");
+            if (gcloudValidation.IsValid)
+            {
+                await GCloudWrapper.GenerateSourceContext(project.DirectoryPath, stageDirectory);
+            }
+
             return result;
         }
     }

GoogleCloudExtension/GoogleCloudExtension.GCloud/GCloudWrapper.cs

@@ -48,13 +48,6 @@ public static class GCloudWrapper
             [ GCloudComponent.Kubectl ] = "kubectl",
         };
 
-        /// <summary>
-        /// Finds the location of gcloud.cmd by following all of the directories in the PATH environment
-        /// variable until it finds it. With this we assume that in order to run the extension gcloud.cmd is
-        /// in the PATH.
-        /// </summary>
-        public static string GetGCloudPath() => PathUtils.GetCommandPathFromPATH("gcloud.cmd");
-
         /// <summary>
         /// Resets, or creates, the password for the given <paramref name="userName"/> in the given instance.
         /// </summary>
@@ -219,7 +212,7 @@ private static async Task<IList<string>> GetInstalledComponentsAsync()
         private static bool IsGCloudCliInstalled()
         {
             Debug.WriteLine("Validating GCloud installation.");
-            var gcloudPath = GetGCloudPath();
+            var gcloudPath = PathUtils.GetCommandPathFromPATH("gcloud.cmd");
             Debug.WriteLineIf(gcloudPath == null, "Cannot find gcloud.cmd in the system.");
             Debug.WriteLineIf(gcloudPath != null, $"Found gcloud.cmd at {gcloudPath}");
             return gcloudPath != null;

GoogleCloudExtension/GoogleCloudExtension/ManageWindowsCredentials/ManageWindowsCredentialsViewModel.cs

@@ -191,6 +191,11 @@ private async Task<WindowsInstanceCredentials> CreateOrResetCredentials(string u
                 }
 
                 Debug.WriteLine($"Resetting the password for the user {user}");
+                if (!await GCloudWrapperUtils.VerifyGCloudDependencies())
+                {
+                    Debug.WriteLine("Gcloud dependencies not met, aborting change of password.");
+                    return null;
+                }
 
                 var context = new GCloudContext
                 {