Remove the vendor directory?

[arschles]

The lowest version number this seems to be building with is 1.12, so in theory the vendor directory could be removed. Is there a reason it needs to stay?

[philips]

Why should the project remove vendor?

[davidnewhall]

Because it causes problems with go modules. Why is it needed? You can always go mod vendor before deploy if you need the files locally.

[philips]

What problems does it cause for you specifically?

I like the vendor because it enables builds with contacting the internet.

[davidnewhall]

I forked this repo and rewrote half the stuff in it a while back. That included removing the vendor folder. This doesn't cause me problems, but with other repos this makes upgrading vendors difficult. Like using yaml.v3 instead of yaml.v2. It's bad practice for public repos.

How do you build the data in this repo without connecting to the Internet to clone it? And if you can clone this repo, can't you clone the two vendor dependencies at the same time?

[philips]

I appreciate that you don't like the vendor directory but you also haven't presented specific problems it is causing.

1. Why is it bad practice on public repos?
2. Why is upgrading vendors difficult? What specific commands are difficult?

[davidnewhall]

Oh I like the vendor director. When I make it. ;) I have no dogs in this fight, so I'll let OP answer your questions.