lint.

Author: ludoch

appengine-java21/springboot-helloworld/src/main/java/com/example/appengine/demos/springboot/HelloworldController.java

@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package com.example.appengine.demos.springboot;
 
 import java.security.Principal;
@@ -42,27 +41,29 @@
 
 /**
  *
- * @author ludo
+ * Simple controller.
  */
 @Controller
 @Slf4j
 public class HelloworldController {
 
-    /** Do something with the app engine datastore... */
-    private final DatastoreService datastoreService;
+    /**
+     * Do something with the app engine datastore...
+     */
+    private final DatastoreService ds;
 
     /**
      *
-     * @param datastoreService
+     * @param datastoreService injected appengine service.
      */
     @Autowired
     public HelloworldController(DatastoreService datastoreService) {
-        this.datastoreService = Objects.requireNonNull(datastoreService);
+        this.ds = Objects.requireNonNull(datastoreService);
     }
 
     /**
-     * Home page -> {@literal /WEB-INF/jsp/index.jsp}
-     * 
+     * Home page -> {@literal /WEB-INF/jsp/index.jsp}.
+     *
      * @return home page view.
      */
     @RequestMapping("/")
@@ -73,7 +74,7 @@ public ModelAndView home() {
 
     /**
      * Sample JSON/HTTP service.
-     * 
+     *
      * @return a list of aliens.
      */
     @RequestMapping(value = "/aliens", method = RequestMethod.GET)
@@ -84,23 +85,25 @@ public AliensResponse aliens() {
     }
 
     /**
-     * /admin endpoint handler
-     * @param request Servlet request
-     * @return
+     * /admin endpoint handler.
+     *
+     * @param request servlet request.
+     * @return the endpoint content.
      */
     @RequestMapping(value = "/admin", method = RequestMethod.GET)
     @ResponseBody
     public AliensResponse admin(final HttpServletRequest request) {
         LOGGER.info("Returning the admin info...");
         Principal userPrincipal = request.getUserPrincipal();
         return AliensResponse.of(
-            Collections.singletonList(Alien.of("userPrincipal", userPrincipal == null ? "null" : userPrincipal.toString()))
+                Collections.singletonList(Alien.of("userPrincipal", userPrincipal == null ? "null" : userPrincipal.toString()))
         );
     }
 
     @Data
     @AllArgsConstructor(staticName = "of")
     static class AliensResponse {
+
         @NonNull
         private final List<Alien> aliens;
     }
@@ -110,6 +113,7 @@ static class AliensResponse {
     // Only used by Jackson through reflection
     @NoArgsConstructor(access = AccessLevel.PRIVATE, force = true)
     static class Alien {
+
         @NonNull
         @NotEmpty
         private final String name;

appengine-java21/springboot-helloworld/src/main/java/com/example/appengine/demos/springboot/ServletInitializer.java

@@ -30,5 +30,4 @@ public class ServletInitializer extends SpringBootServletInitializer {
   protected SpringApplicationBuilder configure(final SpringApplicationBuilder application) {
     return application.sources(SpringBootExampleApplication.class);
   }
-
 }