feat(compute): add compute reservation vms update sample (#9570)

TetyanaYahodska · web-flow · commit 29784f1f831b · 2024-10-28T22:09:03.000+01:00
* Implemented compute_reservation_vms_update, created test * Merged changes from main * Fixed naming * Fixed naming * Fixed test's order * Changed zone * Revert "Changed zone" This reverts commit cfb2d83. * Moved update VM test to ReservationIT * Changed zone * Revert "Changed zone" This reverts commit ae0c86d. * Changed zone * Checked GetReservation in the updateVm test * Revert "Checked GetReservation in the updateVm test" This reverts commit d7eb3ef. * Moved updateVm test to ReservationIT * Fixed whitespaces * Fixed tests * Fixed style * Changed zone
diff --git a/compute/cloud-client/src/main/java/compute/reservation/UpdateVmsForReservation.java b/compute/cloud-client/src/main/java/compute/reservation/UpdateVmsForReservation.java
@@ -0,0 +1,76 @@
+/*
+ * Copyright 2024 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package compute.reservation;
+
+// [START compute_reservation_vms_update]
+
+import com.google.cloud.compute.v1.Operation;
+import com.google.cloud.compute.v1.ReservationsClient;
+import com.google.cloud.compute.v1.ReservationsResizeRequest;
+import com.google.cloud.compute.v1.ResizeReservationRequest;
+import java.io.IOException;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class UpdateVmsForReservation {
+
+  public static void main(String[] args)
+      throws IOException, ExecutionException, InterruptedException, TimeoutException {
+    // TODO(developer): Replace these variables before running the sample.
+    // Project ID or project number of the Cloud project you want to use.
+    String projectId = "YOUR_PROJECT_ID";
+    // The zone where the reservation is located.
+    String zone =  "us-central1-a";
+    // Name of the reservation to update.
+    String reservationName = "YOUR_RESERVATION_NAME";
+    // Number of instances to update in the reservation.
+    int numberOfVms = 3;
+
+    updateVmsForReservation(projectId, zone, reservationName, numberOfVms);
+  }
+
+  // Updates a reservation with new VM capacity.
+  public static void updateVmsForReservation(
+      String projectId, String zone, String reservationName, int numberOfVms)
+      throws IOException, ExecutionException, InterruptedException, TimeoutException {
+    // Initialize client that will be used to send requests. This client only needs to be created
+    // once, and can be reused for multiple requests.
+    try (ReservationsClient reservationsClient = ReservationsClient.create()) {
+
+      ResizeReservationRequest resizeReservationRequest =
+          ResizeReservationRequest.newBuilder()
+              .setProject(projectId)
+              .setZone(zone)
+              .setReservation(reservationName)
+              .setReservationsResizeRequestResource(ReservationsResizeRequest.newBuilder()
+                  .setSpecificSkuCount(numberOfVms)
+                  .build())
+              .build();
+
+      Operation response = reservationsClient.resizeAsync(resizeReservationRequest)
+          .get(3, TimeUnit.MINUTES);
+
+      if (response.hasError()) {
+        System.out.println("Reservation update failed !!" + response);
+        return;
+      }
+      System.out.println("Reservation updated successfully: " + response.getStatus());
+    }
+  }
+}
+// [END compute_reservation_vms_update]
diff --git a/compute/cloud-client/src/test/java/compute/reservation/CrudOperationsReservationIT.java b/compute/cloud-client/src/test/java/compute/reservation/CrudOperationsReservationIT.java
@@ -32,26 +32,28 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 import org.junit.Assert;
-import org.junit.FixMethodOrder;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
 import org.junit.jupiter.api.Timeout;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
-import org.junit.runners.MethodSorters;
 
 @RunWith(JUnit4.class)
-@Timeout(value = 25, unit = TimeUnit.MINUTES)
-@FixMethodOrder(MethodSorters.NAME_ASCENDING)
+@Timeout(value = 6, unit = TimeUnit.MINUTES)
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 public class CrudOperationsReservationIT {
 
   private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
-  private static final String ZONE = "us-west1-a";
-  private static String RESERVATION_NAME;
-  private static final int NUMBER_OF_VMS = 3;
+  private static final String ZONE = "us-central1-b";
   static String javaVersion = System.getProperty("java.version").substring(0, 2);
+  private static final String RESERVATION_NAME = "test-reservation-" + javaVersion + "-"
+      + UUID.randomUUID().toString().substring(0, 8);
+  private static final int NUMBER_OF_VMS = 3;
 
   // Check if the required environment variables are set.
   public static void requireEnvVar(String envVarName) {
@@ -64,8 +66,6 @@ public static void setUp()
       throws IOException, ExecutionException, InterruptedException, TimeoutException {
     requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
     requireEnvVar("GOOGLE_CLOUD_PROJECT");
-    RESERVATION_NAME = "test-reservation-" + javaVersion + "-"
-        + UUID.randomUUID().toString().substring(0, 8);
 
     // Cleanup existing stale resources.
     Util.cleanUpExistingReservations("test-reservation-"  + javaVersion, PROJECT_ID, ZONE);
@@ -84,7 +84,8 @@ public static void cleanup()
   }
 
   @Test
-  public void firstCreateReservationTest()
+  @Order(1)
+  public void testCreateReservation()
       throws IOException, ExecutionException, InterruptedException, TimeoutException {
     final PrintStream out = System.out;
     ByteArrayOutputStream stdOut = new ByteArrayOutputStream();
@@ -99,7 +100,8 @@ public void firstCreateReservationTest()
   }
 
   @Test
-  public void secondGetReservationTest()
+  @Order(3)
+  public void testGetReservation()
       throws IOException {
     Reservation reservation = GetReservation.getReservation(
         PROJECT_ID, RESERVATION_NAME, ZONE);
@@ -109,7 +111,8 @@ public void secondGetReservationTest()
   }
 
   @Test
-  public void thirdListReservationTest() throws IOException {
+  @Order(4)
+  public void testListReservation() throws IOException {
     List<Reservation> reservations =
         ListReservations.listReservations(PROJECT_ID, ZONE);
 
diff --git a/compute/cloud-client/src/test/java/compute/reservation/ReservationIT.java b/compute/cloud-client/src/test/java/compute/reservation/ReservationIT.java
@@ -38,29 +38,37 @@
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
 import org.junit.jupiter.api.Timeout;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 
 @RunWith(JUnit4.class)
-@Timeout(value = 25, unit = TimeUnit.MINUTES)
+@Timeout(value = 6, unit = TimeUnit.MINUTES)
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 public class ReservationIT {
 
   private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
-  private static final String ZONE = "us-west1-a";
+  private static final String ZONE = "asia-south1-a";
   private static final String REGION = ZONE.substring(0, ZONE.lastIndexOf('-'));
-  private static ReservationsClient reservationsClient;
-  private static String RESERVATION_NAME_GLOBAL;
-  private static String RESERVATION_NAME_REGIONAL;
-  private static String GLOBAL_INSTANCE_TEMPLATE_URI;
-  private static String REGIONAL_INSTANCE_TEMPLATE_URI;
   static String javaVersion = System.getProperty("java.version").substring(0, 2);
+  private static ReservationsClient reservationsClient;
+  private static final String RESERVATION_NAME_GLOBAL = "test-reservation-global-" + javaVersion
+      + "-" + UUID.randomUUID().toString().substring(0, 8);
+  private static final String  RESERVATION_NAME_REGIONAL = "test-reservation-regional-"
+      + javaVersion + "-" + UUID.randomUUID().toString().substring(0, 8);
   private static final String GLOBAL_INSTANCE_TEMPLATE_NAME =
       "test-global-inst-temp-" + javaVersion + "-" + UUID.randomUUID().toString().substring(0, 8);
-  private static final String REGIONAL_INSTANCE_TEMPLATE_NAME =
-      "test-regional-inst-temp-" + javaVersion  + "-"
-          + UUID.randomUUID().toString().substring(0, 8);
+  private static final String REGIONAL_INSTANCE_TEMPLATE_NAME = "test-regional-inst-temp-"
+      + javaVersion  + "-" + UUID.randomUUID().toString().substring(0, 8);
+  private static final String GLOBAL_INSTANCE_TEMPLATE_URI = String.format(
+      "projects/%s/global/instanceTemplates/%s", PROJECT_ID, GLOBAL_INSTANCE_TEMPLATE_NAME);
+  private static final String REGIONAL_INSTANCE_TEMPLATE_URI =
+      String.format("projects/%s/regions/%s/instanceTemplates/%s",
+          PROJECT_ID, REGION, REGIONAL_INSTANCE_TEMPLATE_NAME);
   private static final int NUMBER_OF_VMS = 3;
 
   // Check if the required environment variables are set.
@@ -89,16 +97,6 @@ public static void setUp()
     // Initialize the client once for all tests
     reservationsClient = ReservationsClient.create();
 
-    RESERVATION_NAME_GLOBAL = "test-reservation-global-" + javaVersion  + "-"
-        + UUID.randomUUID().toString().substring(0, 8);
-    RESERVATION_NAME_REGIONAL = "test-reservation-regional-" + javaVersion  + "-"
-        + UUID.randomUUID().toString().substring(0, 8);
-    GLOBAL_INSTANCE_TEMPLATE_URI = String.format("projects/%s/global/instanceTemplates/%s",
-        PROJECT_ID, GLOBAL_INSTANCE_TEMPLATE_NAME);
-    REGIONAL_INSTANCE_TEMPLATE_URI =
-        String.format("projects/%s/regions/%s/instanceTemplates/%s",
-            PROJECT_ID, REGION, REGIONAL_INSTANCE_TEMPLATE_NAME);
-
     // Create instance template with GLOBAL location.
     CreateInstanceTemplate.createInstanceTemplate(PROJECT_ID, GLOBAL_INSTANCE_TEMPLATE_NAME);
     assertThat(stdOut.toString())
@@ -152,6 +150,7 @@ public static void cleanup()
   }
 
   @Test
+  @Order(1)
   public void testCreateReservationWithGlobalInstanceTemplate()
       throws IOException, ExecutionException, InterruptedException, TimeoutException {
     CreateReservationForInstanceTemplate.createReservationForInstanceTemplate(
@@ -177,4 +176,17 @@ public void testCreateReservationWithRegionInstanceTemplate()
     Assert.assertTrue(reservation.getZone().contains(ZONE));
     Assert.assertEquals(RESERVATION_NAME_REGIONAL, reservation.getName());
   }
+
+  @Test
+  @Order(2)
+  public void testUpdateVmsForReservation()
+      throws IOException, ExecutionException, InterruptedException, TimeoutException {
+    int newNumberOfVms = 5;
+    UpdateVmsForReservation.updateVmsForReservation(
+        PROJECT_ID, ZONE, RESERVATION_NAME_GLOBAL, newNumberOfVms);
+    Reservation reservation = GetReservation.getReservation(
+        PROJECT_ID, RESERVATION_NAME_GLOBAL, ZONE);
+
+    Assert.assertEquals(newNumberOfVms, reservation.getSpecificReservation().getCount());
+  }
 }
