Skip to content

Commit 382324c

Browse files
Fixed tests
1 parent 49610b4 commit 382324c

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

compute/cloud-client/src/test/java/compute/disks/HyperdisksIT.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ public static void setUp()
6565
STORAGE_POOL_NAME = "test-storage-pool-enc-" + javaVersion + "-"
6666
+ UUID.randomUUID().toString().substring(0, 8);
6767

68-
Util.cleanUpExistingDisks("test-hyperdisk-enc-", PROJECT_ID, ZONE);
69-
Util.cleanUpExistingStoragePool("test-storage-pool-" + javaVersion, PROJECT_ID, ZONE);
68+
7069
}
7170

7271
@AfterAll
@@ -77,6 +76,8 @@ public static void cleanup()
7776
DeleteDisk.deleteDisk(PROJECT_ID, ZONE, HYPERDISK_IN_POOL_NAME);
7877

7978
Util.deleteStoragePool(PROJECT_ID, ZONE, STORAGE_POOL_NAME);
79+
Util.cleanUpExistingDisks("test-hyperdisk-enc-", PROJECT_ID, ZONE);
80+
Util.cleanUpExistingStoragePool("test-" , PROJECT_ID, ZONE);
8081
}
8182

8283
@Test

compute/cloud-client/src/test/java/compute/reservation/CrudOperationsReservationIT.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,6 @@ public static void setUp()
7878
INSTANCE_FOR_RESERVATION = "test-instance-for-reserv-" + javaVersion + "-"
7979
+ UUID.randomUUID().toString().substring(0, 8);
8080

81-
// Cleanup existing stale resources.
82-
Util.cleanUpExistingReservations("test-reservation-" + javaVersion, PROJECT_ID, ZONE);
8381

8482
CreateInstance.createInstance(PROJECT_ID, ZONE, INSTANCE_FOR_RESERVATION);
8583
CreateReservation.createReservation(
@@ -102,6 +100,9 @@ public static void cleanup()
102100
NotFoundException.class,
103101
() -> GetReservation.getReservation(PROJECT_ID, RESERVATION_NAME_FROM_VM, ZONE));
104102

103+
// Cleanup existing stale resources.
104+
Util.cleanUpExistingReservations("test-reservation-" + javaVersion, PROJECT_ID, ZONE);
105+
105106
reservationsClient.close();
106107
instancesClient.close();
107108
}

compute/cloud-client/src/test/java/compute/reservation/ReservationIT.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,6 @@ public static void setUp()
7878
ByteArrayOutputStream stdOut = new ByteArrayOutputStream();
7979
System.setOut(new PrintStream(stdOut));
8080

81-
// Cleanup existing stale resources.
82-
Util.cleanUpExistingInstanceTemplates("test-global-inst-temp-" + javaVersion, PROJECT_ID);
83-
Util.cleanUpExistingRegionalInstanceTemplates(
84-
"test-regional-inst-temp-" + javaVersion, PROJECT_ID, ZONE);
85-
Util.cleanUpExistingReservations(
86-
"test-reserv-global-" + javaVersion, PROJECT_ID, ZONE);
87-
Util.cleanUpExistingReservations("test-reserv-regional-" + javaVersion, PROJECT_ID, ZONE);
8881

8982
// Initialize the client once for all tests
9083
reservationsClient = ReservationsClient.create();
@@ -144,6 +137,14 @@ public static void cleanup()
144137
NotFoundException.class,
145138
() -> GetReservation.getReservation(PROJECT_ID, RESERVATION_NAME_REGIONAL, ZONE));
146139

140+
// Cleanup existing stale resources.
141+
Util.cleanUpExistingInstanceTemplates("test-global-inst-temp-" + javaVersion, PROJECT_ID);
142+
Util.cleanUpExistingRegionalInstanceTemplates(
143+
"test-regional-inst-temp-" + javaVersion, PROJECT_ID, ZONE);
144+
Util.cleanUpExistingReservations(
145+
"test-reserv-global-" + javaVersion, PROJECT_ID, ZONE);
146+
Util.cleanUpExistingReservations("test-reserv-regional-" + javaVersion, PROJECT_ID, ZONE);
147+
147148
// Close the client after all tests
148149
reservationsClient.close();
149150

0 commit comments

Comments
 (0)