Skip to content

Commit 5993a3a

Browse files
Fixed code following the comments
1 parent 5463364 commit 5993a3a

File tree

6 files changed

+23
-25
lines changed

6 files changed

+23
-25
lines changed

compute/cloud-client/src/main/java/compute/disks/StartDiskReplication.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ public static Operation.Status startDiskAsyncReplication(String primaryProjectId
5757
throws IOException, ExecutionException, InterruptedException {
5858
String secondaryDiskPath = String.format("projects/%s/regions/%s/disks/%s",
5959
secondaryProjectId, secondaryDiskLocation, secondaryDiskName);
60-
// Initialize client that will be used to send requests. This client only needs to be created
61-
// once, and can be reused for multiple requests.
6260

6361
// Uncomment these lines if your disk has zonal location.
6462
// try (DisksClient disksClient = DisksClient.create()) {
@@ -67,6 +65,8 @@ public static Operation.Status startDiskAsyncReplication(String primaryProjectId
6765
// .setAsyncSecondaryDisk(secondaryDiskPath)
6866
// .build();
6967

68+
// Initialize client that will be used to send requests. This client only needs to be created
69+
// once, and can be reused for multiple requests.
7070
try (RegionDisksClient disksClient = RegionDisksClient.create()) {
7171

7272
RegionDisksStartAsyncReplicationRequest replicationRequest =
@@ -78,7 +78,7 @@ public static Operation.Status startDiskAsyncReplication(String primaryProjectId
7878
primaryProjectId, primaryDiskLocation, primaryDiskName, replicationRequest).get();
7979

8080
if (response.hasError()) {
81-
System.out.println(response.getError());
81+
System.out.printf("Error starting disk replication: %s%n", response.getError());
8282
return null;
8383
}
8484
return response.getStatus();

compute/cloud-client/src/main/java/compute/disks/StopDiskReplication.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,18 @@ public static void main(String[] args)
4343
public static Operation.Status stopDiskAsyncReplication(
4444
String project, String diskLocation, String diskName)
4545
throws IOException, ExecutionException, InterruptedException {
46-
// Initialize client that will be used to send requests. This client only needs to be created
47-
// once, and can be reused for multiple requests.
4846

4947
// Uncomment this line if your disk has zonal location.
5048
//try (DisksClient disksClient = DisksClient.create()) {
5149

50+
// Initialize client that will be used to send requests. This client only needs to be created
51+
// once, and can be reused for multiple requests.
5252
try (RegionDisksClient disksClient = RegionDisksClient.create()) {
5353
Operation response = disksClient.stopAsyncReplicationAsync(
5454
project, diskLocation, diskName).get();
5555

5656
if (response.hasError()) {
57-
System.out.println(response.getError());
57+
System.out.printf("Error stopping disk replication: %s%n", response.getError());
5858
return null;
5959
}
6060
return response.getStatus();

compute/cloud-client/src/main/java/compute/disks/consistencygroup/AddDiskToConsistencyGroup.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,16 @@ public static Operation.Status addDiskToConsistencyGroup(
6060
// AddResourcePoliciesDiskRequest request =
6161
// AddResourcePoliciesDiskRequest.newBuilder()
6262
// .setDisk(diskName)
63+
// .setZone(location)
64+
// .setProject(project)
6365
// .setDisksAddResourcePoliciesRequestResource(
6466
// DisksAddResourcePoliciesRequest.newBuilder()
6567
// .addAllResourcePolicies(Arrays.asList(consistencyGroupUrl))
6668
// .build())
67-
// .setProject(project)
68-
// .setZone(location)
6969
// .build();
7070

71+
// Initialize client that will be used to send requests. This client only needs to be created
72+
// once, and can be reused for multiple requests.
7173
try (RegionDisksClient disksClient = RegionDisksClient.create()) {
7274
AddResourcePoliciesRegionDiskRequest disksRequest =
7375
AddResourcePoliciesRegionDiskRequest.newBuilder()

compute/cloud-client/src/main/java/compute/disks/consistencygroup/CloneDisksFromConsistencyGroup.java

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,30 +54,24 @@ public static Operation.Status cloneDisksFromConsistencyGroup(String project,
5454
String sourceConsistencyGroupPolicy = String.format(
5555
"projects/%s/regions/%s/resourcePolicies/%s", project, consistencyGroupLocation,
5656
consistencyGroupName);
57+
// Initialize client that will be used to send requests. This client only needs to be created
58+
// once, and can be reused for multiple requests.
5759

58-
// If your disk has zonal location uncomment this code
60+
// Use this client if your disk has zonal location.
5961
//try (DisksClient disksClient = DisksClient.create()){
60-
// BulkInsertDiskRequest request = BulkInsertDiskRequest.newBuilder()
61-
// .setProject(project)
62-
// .setZone(disksLocation)
63-
// .setBulkInsertDiskResourceResource(
64-
// BulkInsertDiskResource.newBuilder()
65-
// .setSourceConsistencyGroupPolicy(sourceConsistencyGroupPolicy)
66-
// .build())
67-
// .build();
68-
//Operation response = disksClient.bulkInsertAsync(request).get(3, TimeUnit.MINUTES);
69-
70-
try (RegionDisksClient regionDisksClient = RegionDisksClient.create()) {
62+
try (RegionDisksClient disksClient = RegionDisksClient.create()) {
7163
BulkInsertRegionDiskRequest request = BulkInsertRegionDiskRequest.newBuilder()
7264
.setProject(project)
7365
.setRegion(disksLocation)
66+
// Set the zone if your disk has zonal location instead of region.
67+
// .setZone(disksLocation)
7468
.setBulkInsertDiskResourceResource(
7569
BulkInsertDiskResource.newBuilder()
7670
.setSourceConsistencyGroupPolicy(sourceConsistencyGroupPolicy)
7771
.build())
7872
.build();
7973

80-
Operation response = regionDisksClient.bulkInsertAsync(request).get(3, TimeUnit.MINUTES);
74+
Operation response = disksClient.bulkInsertAsync(request).get(3, TimeUnit.MINUTES);
8175

8276
if (response.hasError()) {
8377
System.out.printf("Error cloning disks: %s%n", response.getError());

compute/cloud-client/src/main/java/compute/disks/consistencygroup/DeleteDiskConsistencyGroup.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ public static Operation.Status deleteDiskConsistencyGroup(
4343
throws IOException, ExecutionException, InterruptedException {
4444
// Initialize client that will be used to send requests. This client only needs to be created
4545
// once, and can be reused for multiple requests.
46-
try (ResourcePoliciesClient regionResourcePoliciesClient = ResourcePoliciesClient.create()) {
47-
Operation response = regionResourcePoliciesClient
46+
try (ResourcePoliciesClient resourcePoliciesClient = ResourcePoliciesClient.create()) {
47+
Operation response = resourcePoliciesClient
4848
.deleteAsync(project, region, consistencyGroupName).get();
4949

5050
if (response.hasError()) {

compute/cloud-client/src/main/java/compute/disks/consistencygroup/RemoveDiskFromConsistencyGroup.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,16 @@ public static Operation.Status removeDiskFromConsistencyGroup(
6161
// RemoveResourcePoliciesDiskRequest request =
6262
// RemoveResourcePoliciesDiskRequest.newBuilder()
6363
// .setDisk(diskName)
64+
// .setZone(location)
65+
// .setProject(project)
6466
// .setDisksRemoveResourcePoliciesRequestResource(
6567
// DisksRemoveResourcePoliciesRequest.newBuilder()
6668
// .addAllResourcePolicies(Arrays.asList(consistencyGroupUrl))
6769
// .build())
68-
// .setProject(project)
69-
// .setZone(location)
7070
// .build();
7171

72+
// Initialize client that will be used to send requests. This client only needs to be created
73+
// once, and can be reused for multiple requests.
7274
try (RegionDisksClient disksClient = RegionDisksClient.create()) {
7375
RemoveResourcePoliciesRegionDiskRequest disksRequest =
7476
RemoveResourcePoliciesRegionDiskRequest.newBuilder()

0 commit comments

Comments
 (0)