Skip to content

Commit 5becc38

Browse files
Added timeout to delete reservation
1 parent 731c40d commit 5becc38

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

compute/cloud-client/src/main/java/compute/reservation/DeleteReservation.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,8 @@ public static void deleteReservation(String projectId, String zone, String reser
5555
.build();
5656

5757
Operation response = reservationsClient.deleteAsync(
58-
deleteReservationRequest).get(5, TimeUnit.MINUTES);
58+
deleteReservationRequest).get(7, TimeUnit.MINUTES);
5959

60-
if (response.getStatus() == Operation.Status.PENDING) {
61-
// Wait for server update
62-
TimeUnit.MINUTES.sleep(2);
63-
System.out.println("Operation.Status = PENDING");
64-
}
6560
if (response.getStatus() == Operation.Status.DONE) {
6661
System.out.println("Deleted reservation: " + reservationName);
6762
}

compute/cloud-client/src/test/java/compute/reservation/ReservationIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ public static void setUp()
8282
Util.cleanUpExistingInstanceTemplates("test-global-inst-temp-" + javaVersion, PROJECT_ID);
8383
Util.cleanUpExistingRegionalInstanceTemplates(
8484
"test-regional-inst-temp-" + javaVersion, PROJECT_ID, ZONE);
85-
//Util.cleanUpExistingReservations(
86-
// "test-reserv-global-" + javaVersion, PROJECT_ID, ZONE);
85+
Util.cleanUpExistingReservations(
86+
"test-reserv-global-" + javaVersion, PROJECT_ID, ZONE);
8787
Util.cleanUpExistingReservations("test-reserv-regional-" + javaVersion, PROJECT_ID, ZONE);
8888

8989
// Initialize the client once for all tests

0 commit comments

Comments
 (0)