Skip to content

Commit 69e6b04

Browse files
Fixed test
1 parent 7b308f9 commit 69e6b04

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

compute/cloud-client/src/test/java/compute/Util.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package compute;
1818

19+
import static compute.disks.RegionalDelete.deleteRegionalDisk;
1920
import static compute.disks.consistencygroup.DeleteDiskConsistencyGroup.deleteDiskConsistencyGroup;
2021

2122
import com.google.cloud.compute.v1.DeleteStoragePoolRequest;
@@ -286,6 +287,22 @@ && isCreatedBeforeThresholdTime(resourcePolicy.getCreationTimestamp())) {
286287
}
287288
}
288289

290+
// Delete disks which starts with the given prefixToDelete and
291+
// has creation timestamp >24 hours.
292+
public static void cleanUpExistingRegionalDisks(
293+
String prefixToDelete, String projectId, String region)
294+
throws IOException, ExecutionException, InterruptedException, TimeoutException {
295+
try (RegionDisksClient disksClient = RegionDisksClient.create()) {
296+
for (Disk disk : disksClient.list(projectId, region).iterateAll()) {
297+
if (disk.getName().contains(prefixToDelete)
298+
&& disk.getRegion().equals(region)
299+
&& isCreatedBeforeThresholdTime(disk.getCreationTimestamp())) {
300+
deleteRegionalDisk(projectId, region, disk.getName());
301+
}
302+
}
303+
}
304+
}
305+
289306
public static boolean containPrefixToDeleteAndZone(
290307
Object resource, String prefixToDelete, String zone) {
291308
boolean containPrefixAndZone = false;

compute/cloud-client/src/test/java/compute/disks/ConsistencyGroupIT.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
public class ConsistencyGroupIT {
4040
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
4141
private static final String REGION = "us-central1";
42+
private static final String REGION_SECONDARY = "northamerica-northeast1";
4243
private static final String CONSISTENCY_GROUP_NAME =
4344
"test-consistency-group-" + UUID.randomUUID();
4445

@@ -53,6 +54,10 @@ public static void setUp() throws Exception {
5354
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
5455
requireEnvVar("GOOGLE_CLOUD_PROJECT");
5556

57+
// Clean up existing stale resources.
58+
Util.cleanUpExistingRegionalDisks("test-disk-for-consistency-", PROJECT_ID, REGION);
59+
Util.cleanUpExistingRegionalDisks(
60+
"gcloud-test-disk-secondary-regional-", PROJECT_ID, REGION_SECONDARY);
5661
Util.cleanUpExistingConsistencyGroup("test-consistency-group-", PROJECT_ID, REGION);
5762
}
5863

0 commit comments

Comments
 (0)