Skip to content

Commit 6fb9649

Browse files
Fixed test
1 parent 9707742 commit 6fb9649

File tree

3 files changed

+29
-0
lines changed

3 files changed

+29
-0
lines changed

compute/cloud-client/src/test/java/compute/Util.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package compute;
1818

19+
import static compute.disks.consistencygroup.DeleteDiskConsistencyGroup.deleteDiskConsistencyGroup;
20+
1921
import com.google.cloud.compute.v1.DeleteStoragePoolRequest;
2022
import com.google.cloud.compute.v1.Disk;
2123
import com.google.cloud.compute.v1.DisksClient;
@@ -30,6 +32,8 @@
3032
import com.google.cloud.compute.v1.RegionInstanceTemplatesClient;
3133
import com.google.cloud.compute.v1.Reservation;
3234
import com.google.cloud.compute.v1.ReservationsClient;
35+
import com.google.cloud.compute.v1.ResourcePoliciesClient;
36+
import com.google.cloud.compute.v1.ResourcePolicy;
3337
import com.google.cloud.compute.v1.Snapshot;
3438
import com.google.cloud.compute.v1.SnapshotsClient;
3539
import com.google.cloud.compute.v1.StoragePool;
@@ -266,6 +270,21 @@ public static void deleteStoragePool(String project, String zone, String storage
266270
}
267271
}
268272

273+
// Delete storagePools which starts with the given prefixToDelete and
274+
// has creation timestamp >24 hours.
275+
public static void cleanUpExistingConsistencyGroup(
276+
String prefixToDelete, String projectId, String region)
277+
throws IOException, ExecutionException, InterruptedException {
278+
try (ResourcePoliciesClient client = ResourcePoliciesClient.create()) {
279+
for (ResourcePolicy resourcePolicy : client.list(projectId, region).iterateAll()) {
280+
if (containPrefixToDeleteAndZone(resourcePolicy, prefixToDelete, region)
281+
&& isCreatedBeforeThresholdTime(resourcePolicy.getCreationTimestamp())) {
282+
deleteDiskConsistencyGroup(projectId, region, resourcePolicy.getName());
283+
}
284+
}
285+
}
286+
}
287+
269288
public static boolean containPrefixToDeleteAndZone(
270289
Object resource, String prefixToDelete, String zone) {
271290
boolean containPrefixAndZone = false;
@@ -291,6 +310,11 @@ public static boolean containPrefixToDeleteAndZone(
291310
containPrefixAndZone = ((StoragePool) resource).getName().contains(prefixToDelete)
292311
&& ((StoragePool) resource).getZone().contains(zone);
293312
}
313+
if (resource instanceof ResourcePolicy) {
314+
containPrefixAndZone = ((ResourcePolicy) resource).getName().contains(prefixToDelete)
315+
&& ((ResourcePolicy) resource).getRegion()
316+
.contains(zone.substring(0, zone.lastIndexOf('-')));
317+
}
294318
} catch (NullPointerException e) {
295319
System.out.println("Resource not found, skipping deletion:");
296320
}

compute/cloud-client/src/test/java/compute/disks/ConsistencyGroupIT.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static org.junit.Assert.assertEquals;
2121

2222
import com.google.cloud.compute.v1.Operation;
23+
import compute.Util;
2324
import compute.disks.consistencygroup.CreateDiskConsistencyGroup;
2425
import compute.disks.consistencygroup.DeleteDiskConsistencyGroup;
2526
import java.io.IOException;
@@ -51,6 +52,7 @@ public static void requireEnvVar(String envVarName) {
5152
public static void setUp() throws Exception {
5253
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
5354
requireEnvVar("GOOGLE_CLOUD_PROJECT");
55+
Util.cleanUpExistingConsistencyGroup("test-consistency-group-", PROJECT_ID, REGION);
5456
}
5557

5658
@AfterAll

compute/cloud-client/src/test/java/compute/reservation/CrudOperationsReservationIT.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ public static void setUp()
5959
requireEnvVar("GOOGLE_CLOUD_PROJECT");
6060

6161
Util.cleanUpExistingReservations("test-reservation-", PROJECT_ID, ZONE);
62+
Util.cleanUpExistingReservations("test-reservation-", PROJECT_ID, "us-central1-a");
63+
Util.cleanUpExistingReservations("test-reservation-", PROJECT_ID, "asia-south1-a");
64+
6265
CreateReservation.createReservation(PROJECT_ID, RESERVATION_NAME, NUMBER_OF_VMS, ZONE);
6366
}
6467

0 commit comments

Comments
 (0)