[SCC] Fix list notification configs test. (#9580)

Co-authored-by: Owen Huyn <[email protected]>

Author: owenhuyn

security-command-center/snippets/src/main/java/vtwo/notifications/DeleteNotification.java

@@ -42,21 +42,28 @@ public static void main(String[] args) throws IOException {
   public static boolean deleteNotificationConfig(String parentId, String location,
       String notificationConfigId)
       throws IOException {
+    return deleteNotificationConfig(String.format("projects/%s/locations/%s/notificationConfigs/%s",
+        parentId,
+        location,
+        notificationConfigId));
+  }
+
+  // Delete a notification config.
+  // Ensure the ServiceAccount has the "securitycenter.notification.delete" permission
+  public static boolean deleteNotificationConfig(String name)
+      throws IOException {
     // Initialize client that will be used to send requests. This client only needs to be created
     // once, and can be reused for multiple requests. After completing all of your requests, call
     // the "close" method on the client to safely clean up any remaining background resources.
     try (SecurityCenterClient client = SecurityCenterClient.create()) {
 
       DeleteNotificationConfigRequest request = DeleteNotificationConfigRequest.newBuilder()
-          .setName(String.format("projects/%s/locations/%s/notificationConfigs/%s",
-              parentId,
-              location,
-              notificationConfigId))
+          .setName(name)
           .build();
 
       client.deleteNotificationConfig(request);
 
-      System.out.printf("Deleted Notification config: %s%n", notificationConfigId);
+      System.out.printf("Deleted Notification config: %s%n", name);
     }
     return true;
   }

security-command-center/snippets/src/main/java/vtwo/notifications/ListNotification.java

@@ -52,6 +52,7 @@ public static ImmutableList<NotificationConfig> listNotificationConfigs(String p
           .setParent(String.format("projects/%s/locations/%s",
               parentId,
               location))
+          .setPageSize(500)
           .build();
 
       ListNotificationConfigsPagedResponse response = client.listNotificationConfigs(

security-command-center/snippets/src/test/java/vtwo/NotificationIT.java

@@ -19,14 +19,15 @@
 import static com.google.common.truth.Truth.assertThat;
 import static com.google.common.truth.Truth.assertWithMessage;
 
+import com.google.api.gax.rpc.AlreadyExistsException;
 import com.google.cloud.pubsub.v1.TopicAdminClient;
 import com.google.cloud.securitycenter.v2.NotificationConfig;
 import com.google.cloud.testing.junit4.MultipleAttemptsRule;
+import com.google.common.collect.ImmutableList;
 import com.google.pubsub.v1.ProjectTopicName;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.PrintStream;
-import java.util.UUID;
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Before;
@@ -49,8 +50,8 @@ public class NotificationIT {
   private static final String PROJECT_ID = System.getenv("SCC_PROJECT_ID");
   private static final String LOCATION = "global";
   private static final String NOTIFICATION_RULE_CREATE =
-      "random-notification-id-" + UUID.randomUUID();
-  private static final String NOTIFICATION_TOPIC = "test-topic-" + UUID.randomUUID();
+      "random-notification-id";
+  private static final String NOTIFICATION_TOPIC = "test-topic-for-testing";
   private static final int MAX_ATTEMPT_COUNT = 3;
   private static final int INITIAL_BACKOFF_MILLIS = 120000; // 2 minutes
   private static ByteArrayOutputStream stdOut;
@@ -76,8 +77,12 @@ public static void setUp() throws IOException, InterruptedException {
     requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
     requireEnvVar("SCC_PROJECT_ID");
 
-    // Create pubsub topic.
-    createPubSubTopic(PROJECT_ID, NOTIFICATION_TOPIC);
+    try {
+      // Create pubsub topic.
+      createPubSubTopic(PROJECT_ID, NOTIFICATION_TOPIC);
+    } catch (AlreadyExistsException ex) {
+      System.out.printf("%s has already been created.", NOTIFICATION_TOPIC);
+    }
 
     // Create notification rules.
     NotificationConfig result = CreateNotification.createNotificationConfig(PROJECT_ID, LOCATION,
@@ -94,11 +99,13 @@ public static void cleanUp() throws IOException {
     stdOut = new ByteArrayOutputStream();
     System.setOut(new PrintStream(stdOut));
 
-    DeleteNotification.deleteNotificationConfig(PROJECT_ID, LOCATION, NOTIFICATION_RULE_CREATE);
-    assertThat(stdOut.toString()).contains(
-        "Deleted Notification config: " + NOTIFICATION_RULE_CREATE);
+    ImmutableList<NotificationConfig> notificationConfigs =
+        ListNotification.listNotificationConfigs(
+            PROJECT_ID, LOCATION);
 
-    deletePubSubTopic(PROJECT_ID, NOTIFICATION_TOPIC);
+    for (NotificationConfig notificationConfig : notificationConfigs) {
+      DeleteNotification.deleteNotificationConfig(notificationConfig.getName());
+    }
 
     stdOut = null;
     System.setOut(out);