Skip to content

Commit a2eee20

Browse files
Fixed comments
1 parent fad5242 commit a2eee20

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

compute/cloud-client/src/main/java/compute/reservation/ConsumeAnyMatchingReservation.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ public static void createReservation(String projectId, String reservationName,
6666
String minCpuPlatform = "Intel Skylake";
6767
// Machine type of the instances.
6868
String machineType = "n1-standard-4";
69+
6970
// Initialize client that will be used to send requests. This client only needs to be created
7071
// once, and can be reused for multiple requests.
7172
try (ReservationsClient reservationsClient = ReservationsClient.create()) {
@@ -141,7 +142,7 @@ public static void createInstance(String projectId, String zone, String instance
141142
.setName(networkName)
142143
.build();
143144

144-
// Set Reservation Affinity to "ANY"
145+
// Set Reservation Affinity
145146
ReservationAffinity reservationAffinity =
146147
ReservationAffinity.newBuilder()
147148
.setConsumeReservationType(ANY_RESERVATION.toString())

compute/cloud-client/src/main/java/compute/reservation/ConsumeSingleProjectReservation.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public static void main(String[] args)
5151
// Name of the VM instance you want to query.
5252
String instanceName = "YOUR_INSTANCE_NAME";
5353
// Number of the instances.
54-
int numberOfVms = 10;
54+
int numberOfVms = 2;
5555

5656
createReservation(projectId, reservationName, numberOfVms, zone);
5757
createInstance(projectId, zone, instanceName, reservationName);
@@ -100,6 +100,7 @@ public static void createReservation(
100100
}
101101

102102
// Create a new instance with the provided "instanceName" value in the specified project and zone.
103+
// Ensure that the VM's properties match the reservation's VM properties.
103104
public static void createInstance(
104105
String projectId, String zone, String instanceName, String reservationName)
105106
throws IOException, InterruptedException, ExecutionException, TimeoutException {

compute/cloud-client/src/main/java/compute/reservation/ConsumeSpecificSharedReservation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public static void main(String[] args)
5151
// Name of the VM instance you want to query.
5252
String instanceName = "YOUR_INSTANCE_NAME";
5353
// Number of instances.
54-
int numberOfVms = 3;
54+
int numberOfVms = 2;
5555

5656
createReservation(projectId, reservationName, numberOfVms, zone);
5757
createInstance(projectId, zone, instanceName, reservationName);

compute/cloud-client/src/test/java/compute/reservation/ConsumeReservationsIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public static void setUp()
6969
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
7070
requireEnvVar("GOOGLE_CLOUD_PROJECT");
7171

72-
// Initialize the clients once for all tests
72+
// Initialize clients once for all tests
7373
instancesClient = InstancesClient.create();
7474
reservationsClient = ReservationsClient.create();
7575

@@ -95,7 +95,7 @@ public static void setUp()
9595
@AfterAll
9696
public static void cleanup()
9797
throws IOException, ExecutionException, InterruptedException, TimeoutException {
98-
// Clean up the instances
98+
// Delete all instances created for testing.
9999
DeleteInstance.deleteInstance(PROJECT_ID, ZONE, INSTANCE_FOR_SPR);
100100
DeleteInstance.deleteInstance(PROJECT_ID, ZONE, INSTANCE_FOR_ANY_MATCHING);
101101
DeleteInstance.deleteInstance(PROJECT_ID, ZONE, SPECIFIC_SHARED_INSTANCE);
@@ -112,7 +112,7 @@ public static void cleanup()
112112
NotFoundException.class,
113113
() -> GetReservation.getReservation(PROJECT_ID, RESERVATION_SHARED_NAME, ZONE));
114114

115-
// Close the clients after all tests
115+
// Close clients after all tests
116116
reservationsClient.close();
117117
instancesClient.close();
118118
}

0 commit comments

Comments
 (0)