Skip to content

Commit aba231e

Browse files
Fixed code
1 parent 87c3262 commit aba231e

File tree

8 files changed

+12
-20
lines changed

8 files changed

+12
-20
lines changed

compute/cloud-client/src/main/java/compute/disks/CreateDiskSecondaryRegional.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ public static void main(String[] args)
5656
}
5757

5858
// Creates a secondary disk in a specified region.
59-
public static Disk createDiskSecondaryRegional(String projectId, String secondaryProjectId,
60-
String primaryDiskName, String secondaryDiskName, String primaryDiskRegion,
61-
String secondaryDiskRegion, int diskSizeGb)
59+
public static Operation.Status createDiskSecondaryRegional(String projectId,
60+
String secondaryProjectId, String primaryDiskName, String secondaryDiskName,
61+
String primaryDiskRegion, String secondaryDiskRegion, int diskSizeGb)
6262
throws IOException, ExecutionException, InterruptedException, TimeoutException {
6363
// An iterable collection of zone names in which you want to keep
6464
// the new disks' replicas. One of the replica zones of the clone must match
@@ -95,10 +95,9 @@ public static Disk createDiskSecondaryRegional(String projectId, String secondar
9595
.get(3, TimeUnit.MINUTES);
9696

9797
if (response.hasError()) {
98-
System.out.printf("Error creating disk: %s%n", response.getError());
99-
return null;
98+
throw new Error("Error creating disk! " + response.getError());
10099
}
101-
return disksClient.get(secondaryProjectId, secondaryDiskRegion, secondaryDiskName);
100+
return response.getStatus();
102101
}
103102
}
104103
}

compute/cloud-client/src/main/java/compute/disks/StartDiskReplication.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ public static Operation.Status startDiskAsyncReplication(String primaryProjectId
7878
primaryProjectId, primaryDiskLocation, primaryDiskName, replicationRequest).get();
7979

8080
if (response.hasError()) {
81-
System.out.printf("Error starting disk replication: %s%n", response.getError());
82-
return null;
81+
throw new Error("Error starting disk replication! " + response.getError());
8382
}
8483
return response.getStatus();
8584
}

compute/cloud-client/src/main/java/compute/disks/StopDiskReplication.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ public static Operation.Status stopDiskAsyncReplication(
5454
project, diskLocation, diskName).get();
5555

5656
if (response.hasError()) {
57-
System.out.printf("Error stopping disk replication: %s%n", response.getError());
58-
return null;
57+
throw new Error("Error stopping disk replication! " + response.getError());
5958
}
6059
return response.getStatus();
6160
}

compute/cloud-client/src/main/java/compute/disks/consistencygroup/AddDiskToConsistencyGroup.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ public static Operation.Status addDiskToConsistencyGroup(
8484

8585
Operation response = disksClient.addResourcePoliciesAsync(disksRequest).get();
8686
if (response.hasError()) {
87-
System.out.printf("Error adding disk to consistency group: %s%n", response.getError());
88-
return null;
87+
throw new Error("Error adding disk to consistency group! " + response.getError());
8988
}
9089
return response.getStatus();
9190
}

compute/cloud-client/src/main/java/compute/disks/consistencygroup/CloneDisksFromConsistencyGroup.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ public static Operation.Status cloneDisksFromConsistencyGroup(String project,
7474
Operation response = disksClient.bulkInsertAsync(request).get(3, TimeUnit.MINUTES);
7575

7676
if (response.hasError()) {
77-
System.out.printf("Error cloning disks: %s%n", response.getError());
78-
return null;
77+
throw new Error("Error cloning disks! " + response.getError());
7978
}
8079
return response.getStatus();
8180
}

compute/cloud-client/src/main/java/compute/disks/consistencygroup/CreateDiskConsistencyGroup.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@ public static Operation.Status createDiskConsistencyGroup(
5858
regionResourcePoliciesClient.insertAsync(project, region, resourcePolicy).get();
5959

6060
if (response.hasError()) {
61-
System.out.printf("Error creating consistency group: %s%n", response.getError());
62-
return null;
61+
throw new Error("Error creating consistency group! " + response.getError());
6362
}
6463
return response.getStatus();
6564
}

compute/cloud-client/src/main/java/compute/disks/consistencygroup/DeleteDiskConsistencyGroup.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ public static Operation.Status deleteDiskConsistencyGroup(
4848
.deleteAsync(project, region, consistencyGroupName).get();
4949

5050
if (response.hasError()) {
51-
System.out.printf("Error deleting disk: %s%n", response.getError());
52-
return null;
51+
throw new Error("Error deleting disk! " + response.getError());
5352
}
5453
return response.getStatus();
5554
}

compute/cloud-client/src/main/java/compute/disks/consistencygroup/RemoveDiskFromConsistencyGroup.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ public static Operation.Status removeDiskFromConsistencyGroup(
8585

8686
Operation response = disksClient.removeResourcePoliciesAsync(disksRequest).get();
8787
if (response.hasError()) {
88-
System.out.printf("Error removing disk from consistency group: %s%n", response.getError());
89-
return null;
88+
throw new Error("Error removing disk from consistency group! " + response.getError());
9089
}
9190
return response.getStatus();
9291
}

0 commit comments

Comments
 (0)